(fix) updated the procedures app UI by grouping orders by patient #61
Conversation
|
@makombe , @donaldkibet and @ojwanganto have a look |
|
Thanks, @FelixKiprotich350. cc @makombe @donaldkibet |
src/common/commonProps.resource.ts
Outdated
| export interface WorklistProps { | ||
| fulfillerStatus: string; | ||
| } | ||
|
|
||
| export interface ResultsOrderProps { | ||
| order: Result; | ||
| patientUuid: string; | ||
| } | ||
|
|
||
| export interface RejectOrderProps { | ||
| order: Result; | ||
| } | ||
|
|
||
| export interface InstructionsProps { | ||
| order: Result; | ||
| } | ||
|
|
||
| export interface GroupedOrders { | ||
| patientId: string; | ||
| orders: Array<Result>; | ||
| } | ||
| export interface GroupedOrdersTableProps { | ||
| orders: Array<Result>; | ||
| showStatus: boolean; | ||
| showActions: boolean; | ||
| showOrderType: boolean; | ||
| showStatusFilter: boolean; | ||
| showDateFilter: boolean; | ||
| actions: Array<OrderAction>; | ||
| } | ||
|
|
||
| export interface ListOrdersDetailsProps { | ||
| groupedOrders: GroupedOrders; | ||
| showStatus: boolean; | ||
| showActions: boolean; | ||
| showOrderType: boolean; | ||
| actions: Array<OrderAction>; | ||
| } | ||
|
|
||
| export interface OrderAction { | ||
| actionName: string; | ||
| displayPosition: 0 | number; |
There was a problem hiding this comment.
we can name this file appropriately, seems to be types and not resource
There was a problem hiding this comment.
types and interfaces should be centralized on types/index.ts file
src/common/listOrderDetails.scss
Outdated
| margin-left: 1rem; | ||
| margin-top: 2rem; |
There was a problem hiding this comment.
Preferably use carbon spacing
| initialSelectedItem={"All"} | ||
| label="" | ||
| titleText={ | ||
| t("filterOrdersByStatus", "Filter Orders by status") + |
There was a problem hiding this comment.
| t("filterOrdersByStatus", "Filter Orders by status") + | |
| t("filterOrdersByStatus", "Filter orders by status") + |
| style={{ textAlign: "center" }} | ||
| className={styles.noOrdersDiv} | ||
| > | ||
| {t("noOrderAvailable", "No Orders Availalble")} |
There was a problem hiding this comment.
| {t("noOrderAvailable", "No Orders Availalble")} | |
| {t("noOrderAvailable", "No orders available")} |
There was a problem hiding this comment.
Can you also re-attach the video not able to view the attached.
| const workListEntries = props.orders; | ||
| const { t } = useTranslation(); | ||
| const [currentPageSize, setCurrentPageSize] = useState<number>(10); | ||
| const [searchString, setSearchString] = useState<string>(""); |
There was a problem hiding this comment.
We should removed unused imports
| currentPage, | ||
| } = usePagination(searchResults, currentPageSize); | ||
|
|
||
| const pageSizes = [10, 20, 30, 40, 50]; |
There was a problem hiding this comment.
use usePaginationInfo hook to generate this pageSizes its imported from @openmrs/esm-framework
|
@donaldkibet , @ojwanganto and @makombe .... verify if l left out something on the requested changes |
Requirements
For changes to apps
If applicable
Summary
fixed the grouping of orders by patient and displaying the name of the patient alongside his/her total orders pending
Screenshots
screen shot
screen record
procedures-grouping.webm
Related Issue
Other