Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error that occurs when selecting date on Procedure Report Form #63

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

DavidSaruni
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Related Issue

Report Form Before:
procedureb4

Report Form After:
procedureafte

Other

Copy link
Contributor

@donaldkibet donaldkibet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @DavidSaruni.

It would be great to follow up and ensure that the Start Date of the procedure is not set before today, as we don't currently support retrospective data entry. Additionally, please verify that the End Date is always greater than the Start Date. Thanks! 🤝

@donaldkibet donaldkibet merged commit 4e5e0a7 into palladiumkenya:main Aug 20, 2024
5 checks passed
@DavidSaruni
Copy link
Contributor Author

I will Don

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants