Don't repeat CallInfo typedef in luacore.h #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomg
reviewed
Mar 10, 2025
| @@ -23,6 +23,7 @@ BEGIN { | |||
|
|
|||
| } | |||
|
|
|||
| /^typedef struct CallInfo CallInfo;/ { next } # Skip repeated typedefs | |||
There was a problem hiding this comment.
I agree this is much better than the other PR.
The only nitpick is that we already have logic for skipping lines with an include. But here we're using "next" and there we're using "if not then print". I don't have a preference but it would be nice if they worked the same way.
There was a problem hiding this comment.
I can offer this which is perhaps clearer in the logic:
/^typedef struct CallInfo CallInfo;/ { next } # Skip repeated typedefs
is_core_include() { next } # Skip includes for files being merged
{ print } # Print all other lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe the better alternative to pallene-lang/pallene#646