Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the github-actions group with 3 updates #1298

Closed
wants to merge 4 commits into from
Closed

Bump the github-actions group with 3 updates #1298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51d6568
Bump the github-actions group with 3 updates
dependabot[bot] Jan 1, 2024
23a9860
hashFiles based on pyproject.toml, like flask does
pamelafox Jan 15, 2024
d889656
force bust the cache
pamelafox Jan 15, 2024
1153fd8
force bust the cache
pamelafox Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
hash: ${{ steps.hash.outputs.hash }}
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
- uses: actions/setup-python@65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236
- uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c
with:
python-version: '3.x'
cache: 'pip'
Expand All @@ -23,7 +23,7 @@ jobs:
- name: generate hash
id: hash
run: cd dist && echo "hash=$(sha256sum * | base64 -w0)" >> $GITHUB_OUTPUT
- uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32
- uses: actions/upload-artifact@c7d193f32edcb7bfad88892161225aeda64e9392
with:
path: ./dist
provenance:
Expand All @@ -44,7 +44,7 @@ jobs:
permissions:
contents: write
steps:
- uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a
- uses: actions/download-artifact@f44cd7b40bfd40b6aa1cc1b9b5b7bf03d3c67110
- name: create release
run: >
gh release create --draft --repo ${{ github.repository }}
Expand All @@ -61,7 +61,7 @@ jobs:
permissions:
id-token: write
steps:
- uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a
- uses: actions/download-artifact@f44cd7b40bfd40b6aa1cc1b9b5b7bf03d3c67110
# Try uploading to Test PyPI first, in case something fails.
- uses: pypa/gh-action-pypi-publish@2f6f737ca5f74c637829c0f5c3acd0e29ea5e8bf
with:
Expand Down
8 changes: 1 addition & 7 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,10 @@ jobs:
- {name: 'Typing', python: '3.11', tox: typing}
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
- uses: actions/setup-python@65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236
- uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c
with:
python-version: ${{ matrix.python }}
cache: 'pip'
cache-dependency-path: 'requirements/*.txt'
- name: cache mypy
uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84
with:
path: ./.mypy_cache
key: mypy|${{ matrix.python }}|${{ hashFiles('requirements/mypy.txt') }}
if: matrix.tox == 'typing'
- run: pip install tox
- run: tox r -e ${{ matrix.tox }}
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ source = ["flask_sqlalchemy", "tests"]
source = ["src", "*/site-packages"]

[tool.mypy]
cache_dir = "/dev/null"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really want this in pyproject.toml though?

Tip: GitHub nowadays also lets you manually remove cache entries via https://github.com/pallets-eco/flask-sqlalchemy/actions/caches

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't, I'm just messing with things trying to understand what's going awry with all our typing calls.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooo thank you! I didn't know about that, I'll poke at that as well.

python_version = "3.8"
files = ["src/flask_sqlalchemy", "tests"]
show_error_codes = true
Expand Down
Loading