Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable arm64 builds #1285

Closed
wants to merge 15 commits into from
Closed

Enable arm64 builds #1285

wants to merge 15 commits into from

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Sep 6, 2024

WIP

This patch only enables arm64 builds in the CI in preparation for further automation.

Testing completed

  • test coverage exists or has been added/updated
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes
  • If there are breaking changes, there is a supporting migration.

@taariq
Copy link
Contributor

taariq commented Sep 6, 2024

Thanks for the suggestion @alessio.

Set version=2 to suppress goreleaser deprecation
vocal warning.

Clean up go.{mod,sum} before running a build.

Do force CGO_ENABLE=1 - public releases should provided
the audience with thew most common features such as
Ledger support.

Enable darwin builds. Enable aarch64 builds for both linux and
darwin.

Mangle arm64's artifacts names - replace arm64 with aarch64.
Set version=2 to suppress goreleaser deprecation
vocal warning.

Clean up go.{mod,sum} before running a build.

Do force CGO_ENABLE=1 - public releases should provided
the audience with thew most common features such as
Ledger support.

Enable darwin builds. Enable aarch64 builds for both linux and
darwin.

Mangle arm64's artifacts names - replace arm64 with aarch64.

Enable arm64 builds
use latest version

Use --clean to suppress deprecation warnings
@taariq
Copy link
Contributor

taariq commented Sep 6, 2024

Closing as not needed for Paloma.

@taariq taariq closed this Sep 6, 2024
@taariq
Copy link
Contributor

taariq commented Sep 6, 2024

@alessio Paloma validators don't need arm builds right now. This is really for docker containers on the light node side. Closing on Paloma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants