DOC: Correct more typos in code comments #63083
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| num_format_str : optional number format string | ||
| """ | ||
| # Create a XlsxWriter format object. | ||
| # Create an XlsxWriter format object. |
Member
There was a problem hiding this comment.
i think this one is wrong?
Contributor
Author
There was a problem hiding this comment.
@jbrockmendel Yes, "an xlsx" is the correct usage. Even Adobe writes "an xlsx" on their official website.
https://www.adobe.com/uk/acrobat/resources/document-files/spreadsheet-files/xls.html
Member
There was a problem hiding this comment.
The general rule is to use "an" when the starting sound of the word is a vowel. Here, that sound is "Ex".
Member
|
@star1327p - changes to the error message needs to be reflected in the test. See https://github.com/pandas-dev/pandas/actions/runs/19390145720/job/55482468729?pr=63083#step:8:94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct more typos in code comments.
Continued from #63042.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.