Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove routes that can lead to space chats #1757

Merged
merged 8 commits into from
Feb 12, 2025
Merged

Conversation

Kelrap
Copy link
Collaborator

@Kelrap Kelrap commented Feb 10, 2025

Stops users from opening space chats when inviting contacts, and when creating a new space.

This was linked to issues Feb 10, 2025
@Kelrap Kelrap removed a link to an issue Feb 10, 2025
@ggurdin
Copy link
Collaborator

ggurdin commented Feb 10, 2025

@Kelrap Does this include logic to redirect users from the space chat page?

@Kelrap
Copy link
Collaborator Author

Kelrap commented Feb 11, 2025

@ggurdin It does not. I haven't done page redirection before, but I can look into it. Should I use routes.dart as a reference?

@ggurdin
Copy link
Collaborator

ggurdin commented Feb 11, 2025

@Kelrap No, I would just go to the initState function in chat.dart (this is the chat page) and there should be a chunk of pangea code at the bottom of the function. There, just put something like "if (room.isSpace) context.go("/rooms")" and then test it to see how it feels from the user perspective

@Kelrap
Copy link
Collaborator Author

Kelrap commented Feb 11, 2025

Here's how the redirection looks.

Screen.Recording.2025-02-11.at.10.28.08.AM.mov

@ggurdin
Copy link
Collaborator

ggurdin commented Feb 11, 2025

@Kelrap Test and see how it looks when you put the redirection earlier. I'm not sure how much faster it would be

@Kelrap
Copy link
Collaborator Author

Kelrap commented Feb 11, 2025

@ggurdin When I try to put the redirection earlier, it just causes an error. I think users will just have to live with a split second of the page before redirection.

@Kelrap
Copy link
Collaborator Author

Kelrap commented Feb 11, 2025

I think joining a space via code can lead to space chat page too. I'll work on that.

@Kelrap
Copy link
Collaborator Author

Kelrap commented Feb 11, 2025

For some reason Learning Settings doesn't work?

Screenshot 2025-02-11 at 11 32 58 AM

I can't click off to close the popup. The issue doesn't happen on web staging, so it's probably caused by something from this specific branch.

Either that, or it's freezing because I'm running the code and using chrome.

@ggurdin
Copy link
Collaborator

ggurdin commented Feb 11, 2025

@Kelrap Is it working in the main branch?

@Kelrap
Copy link
Collaborator Author

Kelrap commented Feb 11, 2025

The problem also occurs in the main branch. It's likely a me-specific problem.

Unless web staging does not automatically update to match the main branch. In which case, it might be a main-specific problem.

@ggurdin
Copy link
Collaborator

ggurdin commented Feb 11, 2025

@Kelrap Yeah, it sounds like it's not related to changes in this branch. Are you able to close the dialog and keep using the app, or does the app freeze when you open the learning settings dialog?

@ggurdin ggurdin merged commit a218591 into main Feb 12, 2025
4 of 5 checks passed
@ggurdin ggurdin deleted the block-space-chat-routes branch February 12, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find and fix all routes to space (chat)
2 participants