-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove routes that can lead to space chats #1757
Conversation
@Kelrap Does this include logic to redirect users from the space chat page? |
@ggurdin It does not. I haven't done page redirection before, but I can look into it. Should I use routes.dart as a reference? |
@Kelrap No, I would just go to the initState function in chat.dart (this is the chat page) and there should be a chunk of pangea code at the bottom of the function. There, just put something like "if (room.isSpace) context.go("/rooms")" and then test it to see how it feels from the user perspective |
Here's how the redirection looks. Screen.Recording.2025-02-11.at.10.28.08.AM.mov |
@Kelrap Test and see how it looks when you put the redirection earlier. I'm not sure how much faster it would be |
…k-space-chat-routes
…at/client into block-space-chat-routes
@ggurdin When I try to put the redirection earlier, it just causes an error. I think users will just have to live with a split second of the page before redirection. |
I think joining a space via code can lead to space chat page too. I'll work on that. |
@Kelrap Is it working in the main branch? |
The problem also occurs in the main branch. It's likely a me-specific problem. Unless web staging does not automatically update to match the main branch. In which case, it might be a main-specific problem. |
@Kelrap Yeah, it sounds like it's not related to changes in this branch. Are you able to close the dialog and keep using the app, or does the app freeze when you open the learning settings dialog? |
Stops users from opening space chats when inviting contacts, and when creating a new space.