Fix s:ExprCol() sometimes go into infinity loop when calculating indent #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I didn't fix it correctly, hope you help (ノω・。) |
shirohana
force-pushed
the
fix/indent-infinity-loop
branch
from
088b268
to
93c8f23
Compare
shirohana
force-pushed
the
fix/indent-infinity-loop
branch
from
93c8f23
to
599db67
Compare
|
example code pls |
|
Actually, you are using an older version of the indent script, please install the latest master from this repo |
|
or your pr is on master, but the trace shows an older version |
|
Hello (: How many tabs and buffers are we talking about? 🤔 |
|
Hello (´・ω・｀) It's around 6 tabs and every tab contains at least 4 buffers. I'll check is it the bug has been fixed later, or I will rebase this pr onto master (๑ơ ω ơ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea how to reproduce it in a simple way...
In the case, I'm working with several tabs and buffers,
when I edit a
.vuefile, I typing o (or CR, O, S, cc that will insert a newline), it happened.But when I open only one
.vuefile, that will fall into infinity loop before, it works correctly...And not only
.vuebut.jscould cause the same error when lots of buffer was opened.Sorry for no helpful information about it (ノω・。)