CA1854 avoid double dictionary lookup

PanoramicData.Blazor.Demo/Data/TestFileSystemDataProvider.cs

@@ -270,13 +270,13 @@ public async Task<OperationResponse> UpdateAsync(FileExplorerItem item, IDiction
 
 		await Task.Run(() =>
 		{
-			if (!delta.ContainsKey("Path"))
+			if (!delta.TryGetValue("Path", out object? value))
 			{
 				result.ErrorMessage = "Only Path property update supported";
 				return;
 			}
 
-			var tempPath = delta["Path"]?.ToString() ?? string.Empty;
+			var tempPath = value?.ToString() ?? string.Empty;
 			var tempItem = new FileExplorerItem { Path = tempPath ?? string.Empty, Name = FileExplorerItem.GetNameFromPath(tempPath) };
 			var targetNode = _root.Where(x => x.Path() == tempItem.Path).FirstOrDefault();
 			var targetParentNode = targetNode is null ? _root.Where(x => x.Path() == tempItem.ParentPath).FirstOrDefault() : targetNode.Parent;

PanoramicData.Blazor.Demo/Shared/DemoSourceView.razor.cs

@@ -95,9 +95,8 @@ private async Task<string> LoadSourceAsync(string url)
 
 	private async Task OnFileClick(string name)
 	{
-		if (_sourceFiles.ContainsKey(name))
+		if (_sourceFiles.TryGetValue(name, out SourceFile? sourceFile))
 		{
-			var sourceFile = _sourceFiles[name];
 			if (string.IsNullOrWhiteSpace(sourceFile.Content))
 			{
 				sourceFile.Content = await LoadSourceAsync(sourceFile.Url).ConfigureAwait(true);

PanoramicData.Blazor/Extensions/IQueryableExtensions.cs

@@ -17,9 +17,9 @@ public static IQueryable<T> ApplyFilter<T>(this IQueryable<T> query, Filter filt
 			// determine property name to use in query
 			if (string.IsNullOrEmpty(filter.PropertyName))
 			{
-				if (keyProperyMappings != null && keyProperyMappings.ContainsKey(filter.Key))
+				if (keyProperyMappings != null && keyProperyMappings.TryGetValue(filter.Key, out string? value))
 				{
-					filter.PropertyName = keyProperyMappings[filter.Key];
+					filter.PropertyName = value;
 				}
 				else
 				{

PanoramicData.Blazor/Models/DataProviderBase.cs

@@ -108,9 +108,9 @@ public virtual Expression<Func<T, bool>> ApplyFilter(Expression<Func<T, bool>>?
 		// determine property name to use in query
 		if (string.IsNullOrEmpty(filter.PropertyName))
 		{
-			if (keyPropertyMappings != null && keyPropertyMappings.ContainsKey(filter.Key))
+			if (keyPropertyMappings != null && keyPropertyMappings.TryGetValue(filter.Key, out string? value))
 			{
-				filter.PropertyName = keyPropertyMappings[filter.Key];
+				filter.PropertyName = value;
 			}
 			else
 			{

PanoramicData.Blazor/PDFileExplorer.razor.cs

@@ -1865,14 +1865,14 @@ private async Task GetUploadConflictsAsync(MoveCopyArgs args)
 				CachedResult<Task<DataResponse<FileExplorerItem>>>? cachedTask = null;
 				lock (_conflictCache)
 				{
-					if (_conflictCache.ContainsKey(folderPath) && _conflictCache[folderPath].HasExpired)
+					if (_conflictCache.TryGetValue(folderPath, out CachedResult<Task<DataResponse<FileExplorerItem>>>? value) && value.HasExpired)
 					{
 						_conflictCache.Remove(folderPath);
 					}
 
-					if (_conflictCache.ContainsKey(folderPath))
+					if (_conflictCache.TryGetValue(folderPath, out CachedResult<Task<DataResponse<FileExplorerItem>>>? value))
 					{
-						cachedTask = _conflictCache[folderPath];
+						cachedTask = value;
 					}
 					else
 					{

PanoramicData.Blazor/PDForm.razor.cs

@@ -448,9 +448,9 @@ private async Task ApplyDelta(TItem item)
 		var memberInfo = field.Field?.GetPropertyMemberInfo();
 		if (memberInfo is PropertyInfo propInfo)
 		{
-			if (updatedValue && Delta.ContainsKey(memberInfo.Name))
+			if (updatedValue && Delta.TryGetValue(memberInfo.Name, out object? value))
 			{
-				value = Delta[memberInfo.Name];
+				value = value;
 			}
 			else
 			{
@@ -581,9 +581,9 @@ public string GetFieldStringValue(FormField<TItem> field, bool updatedValue)
 		var memberInfo = field.Field?.GetPropertyMemberInfo();
 		if (memberInfo is PropertyInfo propInfo)
 		{
-			if (updatedValue && Delta.ContainsKey(memberInfo.Name))
+			if (updatedValue && Delta.TryGetValue(memberInfo.Name, out object? value))
 			{
-				value = Delta[memberInfo.Name];
+				value = value;
 			}
 			else
 			{

PanoramicData.Blazor/PDTable.razor.cs

@@ -669,9 +669,9 @@ public async Task CommitEditAsync()
 			var args = new TableAfterEditEventArgs<TItem>(EditItem);
 			foreach (var column in ActualColumnsToDisplay)
 			{
-				if (_editValues.ContainsKey(column.Id) && IsColumnInEditMode(column, EditItem))
+				if (_editValues.TryGetValue(column.Id, out object? value) && IsColumnInEditMode(column, EditItem))
 				{
-					args.NewValues.Add(column.Id, _editValues[column.Id]);
+					args.NewValues.Add(column.Id, value);
 				}
 			}
 
@@ -682,10 +682,8 @@ public async Task CommitEditAsync()
 				// apply edit value to each column
 				foreach (var column in ActualColumnsToDisplay)
 				{
-					if (args.NewValues.ContainsKey(column.Id))
+					if (args.NewValues.TryGetValue(column.Id, out object? newValue))
 					{
-						// get new value (possible updated by host app) and attempt to set on edit item
-						var newValue = args.NewValues[column.Id];
 						try
 						{
 							column.SetValue(EditItem, newValue);

PanoramicData.Blazor/PDTree.razor.cs

@@ -619,7 +619,7 @@ private void UpdateModel(IEnumerable<TItem> items)
 			}
 			else
 			{
-				parentNode = (dict.ContainsKey(parentKey)) ? parentNode = dict[parentKey] : RootNode.Find(parentKey);
+				parentNode = (dict.TryGetValue(parentKey, out TreeNode<TItem>? value)) ? parentNode = value : RootNode.Find(parentKey);
 			}
 
 			if (parentNode == null)