CA1868 prefer char literal

panoramicdata · Jan 3, 2025 · 5c1ad6b · 5c1ad6b
1 parent 9bf9ca7
commit 5c1ad6b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/PanoramicData.Blazor/Extensions/IQueryableExtensions.cs b/PanoramicData.Blazor/Extensions/IQueryableExtensions.cs
@@ -43,10 +43,11 @@ public static IQueryable<T> ApplyFilter<T>(this IQueryable<T> query, Filter filt
 			// apply query only if property name is known
 			if (!string.IsNullOrWhiteSpace(filter.PropertyName))
 			{
+				string[] separatorArray = ["|"];
 				object[] parameters = filter.FilterType switch
 				{
-					FilterTypes.In => filter.Value.Split(new[] { "|" }, StringSplitOptions.RemoveEmptyEntries).Select(x => x.RemoveQuotes()).ToArray(),
-					FilterTypes.NotIn => filter.Value.Split(new[] { "|" }, StringSplitOptions.RemoveEmptyEntries).Select(x => x.RemoveQuotes()).ToArray(),
+					FilterTypes.In => filter.Value.Split(separatorArray, StringSplitOptions.RemoveEmptyEntries).Select(x => x.RemoveQuotes()).ToArray(),
+					FilterTypes.NotIn => filter.Value.Split(separatorArray, StringSplitOptions.RemoveEmptyEntries).Select(x => x.RemoveQuotes()).ToArray(),
 					FilterTypes.Range => [filter.Value.RemoveQuotes(), filter.Value2.RemoveQuotes()],
 					FilterTypes.IsEmpty => [string.Empty],
 					FilterTypes.IsNotEmpty => [string.Empty],

diff --git a/PanoramicData.Blazor/Extensions/StringExtensions.cs b/PanoramicData.Blazor/Extensions/StringExtensions.cs
@@ -85,7 +85,7 @@ public static string QuoteIfContainsWhitespace(this string text)
 	{
 		if (text.Length > 0)
 		{
-			if (!(text.StartsWith("\"", StringComparison.Ordinal) && text.StartsWith("\"", StringComparison.Ordinal)) && !(text.StartsWith("#", StringComparison.Ordinal) && text.StartsWith("#", StringComparison.Ordinal)))
+			if (!(text.StartsWith('"') && text.StartsWith('"')) && !(text.StartsWith('#') && text.StartsWith('#')))
 			{
 				if (text.Contains(' ') || text.Contains('\t') || text.Contains('\r') || text.Contains('\n'))
 				{
@@ -99,7 +99,7 @@ public static string QuoteIfContainsWhitespace(this string text)
 
 	public static string RemoveQuotes(this string text)
 	{
-		if (text.StartsWith("\"", StringComparison.Ordinal) && text.EndsWith("\"", StringComparison.Ordinal))
+		if (text.StartsWith('"') && text.EndsWith('"'))
 		{
 			return text[1..^1];
 		}