Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypt session cache #8666

Merged
merged 6 commits into from
Mar 28, 2024
Merged

Encrypt session cache #8666

merged 6 commits into from
Mar 28, 2024

Conversation

hawkeyetwolf
Copy link
Contributor

@hawkeyetwolf hawkeyetwolf commented Sep 1, 2023

Summary

Authenticate Terminus in a GitHub Actions Pipeline - Replaces session cache with encrypted session cache. It would be great to transfer this action to the Pantheon GitHub org and then publish it to the GitHub Marketplace, but okay to leave under the Lullabot org for now.

Effect

The following changes are already committed:

Remaining Work and Prerequisites

The following changes still need to be completed:

Dependencies and Timing

  • Consider transferring action from the Lullabot GitHub org to Pantheon's and update this PR before merging

Release:

  • When ready
  • After date: $DATE

Post Launch

Do not remove - To be completed by the docs team upon merge:

  • Redirect /old-path/ => /new-path/ (if applicable)
  • Include/exclude pages ^ respectively within docs search service provider (if applicable)
  • For Heroes - add a props post to the discussion board.
  • Remove from the project board

Copy link
Contributor

@kporras07 kporras07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hawkeyetwolf this looks great!

Could you please apply my suggestions now that we merged your work into our official Github Actions?

Other than that, this LGTM :)

source/content/terminus/ci/github-actions.md Outdated Show resolved Hide resolved
source/content/terminus/ci/github-actions.md Outdated Show resolved Hide resolved
stevector and others added 2 commits March 27, 2024 09:41
Co-authored-by: Kevin Porras <kporras07@gmail.com>
Co-authored-by: Kevin Porras <kporras07@gmail.com>
@stevector
Copy link
Contributor

@kporras07 Hawkeye passed away in October so I accepted the proposed changes.

Thanks again @hawkeyetwolf for all of your contributions to the community.

@stevector
Copy link
Contributor

@kporras07 once you re-review I can press merge.

@kporras07 kporras07 self-requested a review March 27, 2024 16:35
Copy link
Contributor

@kporras07 kporras07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevector stevector merged commit 4eaf666 into pantheon-systems:main Mar 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants