Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the recommended s3 policy in s3 offload media #8731

Merged
merged 5 commits into from
Jun 14, 2024

Conversation

carl-alberto
Copy link
Contributor

Closes #8730

Summary

Reviewed the policy outlined, it seems it is outdated as reported by 2 customers

Effect

The following changes are already committed:

  • updated s3 config in the PR

Remaining Work and Prerequisites

The following changes still need to be completed:

  • List any outstanding work here

Dependencies and Timing

  • Other prerequisites that must be completed before merging this PR

Release:

  • When ready
  • After date: $DATE

Post Launch

Do not remove - To be completed by the docs team upon merge:

  • Redirect /old-path/ => /new-path/ (if applicable)
  • Include/exclude pages ^ respectively within docs search service provider (if applicable)
  • For Heroes - add a props post to the discussion board.
  • Remove from the project board

@carl-alberto carl-alberto requested a review from a team as a code owner October 10, 2023 14:31
@pantheon-decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-8731-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@stevector
Copy link
Contributor

stevector commented Mar 28, 2024

@carl-alberto who else can review the accuracy of the change? I don't have the subject matter expertise to do so myself.

@stevector stevector added the Process: Needs SME Issue or PR that won't move forward without subject-matter expert contribution label Jun 12, 2024
@miriamgoldman
Copy link
Contributor

miriamgoldman commented Jun 12, 2024

@stevector hi! I have verified that these settings do work. I tested on my sandbox site, and the files are directly offloaded to the S3 bucket. It should be noted that this PR removes access to list the buckets, which is an option with the WP Offload Media plugin. Can we rely on customers to copy/paste their bucket name appropriately for configuration? Since the bucket listing is a feature in the plugin, this gives me pause at face value.

Also, the screenshot needs to be updated.

If so, I'd say this is a pass (save for the screenshot). If not, I can play around with the permissions and get the bucket listing going.

@stevector
Copy link
Contributor

Can we rely on customers to copy/paste their bucket name appropriately for configuration?

I've never used this plugin, but I just based on the level of prescriptive detail already in this page of Docs, I think that if we tell the reader that they need to copy/paste the bucket name that it'll be fine.

If you're trying this out on your own S3, can you take updated screenshots?

@miriamgoldman
Copy link
Contributor

Can we rely on customers to copy/paste their bucket name appropriately for configuration?

I've never used this plugin, but I just based on the level of prescriptive detail already in this page of Docs, I think that if we tell the reader that they need to copy/paste the bucket name that it'll be fine.

Ok, great! I wasn't sure.

If you're trying this out on your own S3, can you take updated screenshots?

Absolutely. I'll get that in tomorrow and tag you here/in Slack.

@miriamgoldman
Copy link
Contributor

@stevector As I'm not a docs admin, I haven't actually hit the review button, but I've added the updated screenshot - and added a note where it talks about using the full S3 access permission regarding needing that if you want to list buckets. LGTM now. Off to you. 🙂

@stevector stevector self-assigned this Jun 13, 2024
@stevector
Copy link
Contributor

I'm removing the old .png and will review more once the preview deployment completes.

@stevector
Copy link
Contributor

I'm not sure why deployments are failing here, investigating.

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-8731-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@stevector stevector merged commit c2f19b9 into main Jun 14, 2024
8 checks passed
@stevector stevector deleted the 8730-update-s3config branch June 14, 2024 15:38
@stevector
Copy link
Contributor

Thanks @miriamgoldman!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Process: Needs SME Issue or PR that won't move forward without subject-matter expert contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WordPress Developer's Guide Doc Update
3 participants