Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMSP-942] PHP < 7.2 EOS #8896

Merged
merged 18 commits into from
Mar 21, 2024
Merged

[CMSP-942] PHP < 7.2 EOS #8896

merged 18 commits into from
Mar 21, 2024

Conversation

pwtyler
Copy link
Member

@pwtyler pwtyler commented Mar 19, 2024 •
edited
Loading

Summary

Release Notes - Adds release note for PHP EoS

Preview

https://pr-8896-documentation.appa.pantheon.site/release-notes/2024/03/PHP-7-1-EOS
https://pr-8896-documentation.appa.pantheon.site/guides/php

Release:

  • When ready

Post Launch

Do not remove - To be completed by the docs team upon merge:

  • Redirect /old-path/ => /new-path/ (if applicable)
  • Include/exclude pages ^ respectively within docs search service provider (if applicable)
  • For Heroes - add a props post to the discussion board.
  • Remove from the project board

@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-8896-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@pwtyler pwtyler marked this pull request as ready for review March 19, 2024 04:19
@pwtyler pwtyler requested a review from a team as a code owner March 19, 2024 04:19
@pwtyler pwtyler requested review from scottbuscemi and a team March 19, 2024 04:19
scottbuscemi
scottbuscemi requested changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@scottbuscemi scottbuscemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comments

source/releasenotes/2024-03-18-PHP-7-1-EOS.md Outdated Show resolved Hide resolved
source/releasenotes/2024-03-18-PHP-7-1-EOS.md Outdated Show resolved Hide resolved
source/releasenotes/2024-03-18-PHP-7-1-EOS.md Outdated Show resolved Hide resolved
@pwtyler pwtyler requested review from scottbuscemi and a team March 19, 2024 06:10
@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-8896-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

jazzsequence
jazzsequence previously approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@jazzsequence jazzsequence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IngridKwok
Copy link
Contributor

@stevector @pwtyler Reviewed with minor changes.

@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-8896-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-8896-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-8896-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

scottbuscemi
scottbuscemi previously requested changes Mar 19, 2024
View reviewed changes
source/releasenotes/2024-03-18-PHP-7-1-EOS.md Outdated Show resolved Hide resolved
@pwtyler pwtyler requested a review from scottbuscemi March 19, 2024 20:52
@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-8896-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@pwtyler pwtyler mentioned this pull request Mar 19, 2024
Closed
5 tasks
@pwtyler pwtyler requested a review from a team as a code owner March 19, 2024 23:23
@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-8896-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@pwtyler pwtyler requested a review from jazzsequence March 19, 2024 23:30
@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-8896-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@pwtyler pwtyler marked this pull request as draft March 19, 2024 23:45
@pwtyler
Copy link
Member Author

pwtyler commented Mar 19, 2024

Flipped to draft, markdown link does not work as expected in the info block, and I'm not sure I like the footnote alert style anyway.

@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-8896-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-8896-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

1 similar comment
@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-8896-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

jazzsequence
jazzsequence reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@jazzsequence jazzsequence left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the rendered source and the two sups were not wrapped in <p> tags. Wrapping them should fix the styling, but you might need to add an actual <a> tag to the link.

(screenshot after hacking markup in the browser)
Screenshot 2024-03-20 at 9 08 21 AM

source/content/guides/php/01-introduction.md Outdated Show resolved Hide resolved
source/content/guides/php/01-introduction.md Outdated Show resolved Hide resolved
@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-8896-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-8896-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-8896-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-8896-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@pwtyler pwtyler marked this pull request as ready for review March 20, 2024 19:43
@pwtyler pwtyler dismissed stale reviews from scottbuscemi and jazzsequence March 20, 2024 19:43

resolved

@pwtyler pwtyler requested a review from jazzsequence March 20, 2024 19:44
@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-8896-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

scottbuscemi
scottbuscemi previously requested changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@scottbuscemi scottbuscemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new relic text swap

source/content/guides/php/01-introduction.md Outdated Show resolved Hide resolved
@pwtyler pwtyler requested a review from scottbuscemi March 20, 2024 20:30
@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-8896-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@jazzsequence jazzsequence merged commit ccc0cdc into main Mar 21, 2024
8 checks passed
@jazzsequence jazzsequence deleted the CMSP-942 branch March 21, 2024 14:17
rachelwhitton pushed a commit that referenced this pull request Mar 28, 2024
@pwtyler @IngridKwok
@jazzsequence @rachelwhitton
[CMSP-942] PHP < 7.2 EOS (#8896)
a6a13bc 
* [CMSP-942] PHP < 7.2 EOS

* Apply suggestions from code review

* Update 2024-03-18-PHP-7-1-EOS.md

* Update 2024-03-18-PHP-7-1-EOS.md

* adjust site creation language

* Update source/releasenotes/2024-03-18-PHP-7-1-EOS.md

* relative path for docs

* Adjust PHP EoS language in primary PHP Doc

* note in php docs

* make alert a footnote

* Try without calling so much attention

* extra space

* Apply suggestions from code review

Co-authored-by: Chris Reynolds <chris.reynolds@pantheon.io>

* hmtl not markdown

* bump date

* line break

* directions are hard

* Update source/content/guides/php/01-introduction.md

---------

Co-authored-by: Ingrid <148255657+IngridKwok@users.noreply.github.com>
Co-authored-by: Chris Reynolds <chris.reynolds@pantheon.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevector stevector stevector left review comments

@jazzsequence jazzsequence jazzsequence approved these changes

@scottbuscemi scottbuscemi Awaiting requested review from scottbuscemi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pwtyler @IngridKwok @stevector @jazzsequence @scottbuscemi