Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Pages to delete and redirect #9335

Merged
merged 16 commits into from
Dec 18, 2024
Merged

WIP - Pages to delete and redirect #9335

merged 16 commits into from
Dec 18, 2024

Conversation

rachelwhitton
Copy link
Member

@rachelwhitton rachelwhitton commented Dec 2, 2024

Summary

Deletes pages, updates impacted links, some consolidations

Post-Merge Redirects Required

@rachelwhitton rachelwhitton self-assigned this Dec 2, 2024
@rachelwhitton rachelwhitton requested review from a team as code owners December 2, 2024 22:03
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9335-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9335-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9335-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9335-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@rachelwhitton rachelwhitton requested a review from a team as a code owner December 4, 2024 15:18
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9335-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9335-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9335-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9335-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9335-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@rachelwhitton
Copy link
Member Author

@stevector is it a problem that a deleted guide is still present here in this file? https://github.com/pantheon-systems/documentation/blob/redirects-new-nav/src/components/omniSidebarNav/testfixtures/allGuides.testfixture.js#L4053-L4148

I tried to remove these lines locally but had issues with pushing the change because the git hook errors:
Screenshot 2024-12-04 at 12 01 42 PM

So I just left them in the file as they are, hoping that's not an issue?

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9335-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@stevector
Copy link
Contributor

hoping that's not an issue?

I don't think it's an issue because this is a test fixture (sample data) that is used to confirm the behavior/logic of the helper functions that reshape the data from what comes out of graphQL to what goes into the menu components.

@rachelwhitton rachelwhitton added the Site: Design Issues about the design of of the site, often regressions label Dec 18, 2024
@rachelwhitton rachelwhitton merged commit 2121e87 into main Dec 18, 2024
12 checks passed
rachelwhitton added a commit that referenced this pull request Dec 18, 2024
* moving deck chairs

* removing a too small function. And removing sample unit test

* deleting separate sidebarNav component

* moving test fixture

* simplyfing a function

* simplify data structures

* running prettier

* checking for search js before adding it

* cleanup

* adding some doc blocks and minor refactor

* docs and cleanup

* more comments

* more cleanup

* more comments more tests

* adding all the front-end sites guides

* removing extra nav alert in the middle of decouple overview pages

* running prettier

* going back to old prettier config files. Redo this change under #9082

* reporting files

* reporting tests

* more reporting tools

* tests for reporting

* more tests and console logging

* moving reporting function

* more testing of reporting

* reporting

* getting percentages calculated

* adding contributors for exceptions examples

* starting to unwind logic error that had percentages reversed

* fixing logic

* more logic fixing

* getting close

* 8%!

* removing unused stuff

* adding to menu

* more menus

* 55%

* migrating and upgrading guides

* more guides in menus

* 199!

* updating exceptions

* Adding menu to video template

* putting omni items in doc template

* starting on DNS

* putting everything in a menu

* more sidebars

* moving simpleLink to helper

* breaking out file for submenu

* breaking out menus

* two more

* breaking out menus

* assigning menus

* a few more assignments

* getting doc template with sidebar

* dns menus

* lots of menu moving

* Drupal and WordPress separate menus

* moving menus

* adding about section

* everything in a top level menu

* build tools menu link

* comment about nested docroot

* starting to add a styling file for omnisidebarnav

* starting on styling

* getting external link indicator working

* remove extra arrow in link

* removing console.log

* workflows()

* getting rendering of default docs pages working

* code organizing

* adding comment

* adding comments

* reporting on status codes

* Moving submenus around

* more

* Adding label

* Add vitest to GitHub actions (#9162)

* Add vitest to GHA

* Make a clean install

* switching from jsx to React.createElement()

* Update and rename test.yml to vitest.yml

---------

Co-authored-by: Steve Persch <steve.persch@pantheon.io>
Co-authored-by: Steve Persch <stevector@users.noreply.github.com>

* moving icon to back and setting to small

* testing readme

* fixing link

* copy fix

* changing addsearch back

* addsearch back

* adding vite.config.ts

* some menu restructuring

* menu reorgs

* fixing page title

* drupal notes and DNS titles

* Refining menus with Rachel and Chris. And adding some JS todos

* more menu tweaks with Rachel and Chris

* fixup terminus template and submenu

* whitespace to trigger build

* more menu tweaking

* terminus menu

* adding a comment to a md file

* working out a top-level nav

* Coworking on submenus - integrations

* manually bringing over files from main before merging

* manually bringing over prettier config change from main

* running prettier on some of the files in omniSidebarNav

* Apply Prettier formatting

* renaming dnsProviders

* working on the migrate section

* Apply Prettier formatting

* Migration submenu edits

* Apply Prettier formatting

* Combine migration and getstarted submenus

* Debug migration nested submenu

* Apply Prettier formatting

* Fix link to getstarted submenu

* test pre-push hook

* test pre-push hook

* add prettier pre-push hook to .github/hooks

* add git hooks section to readme

* actually add the changed files to git

* White spaces

* Apply Prettier formatting

* Apply Prettier formatting

* Support submenu

* Apply Prettier formatting

* Move troubleshooting menu from webinfra

* Apply Prettier formatting

* Edits to support submenu

* Apply Prettier formatting

* Edits to accountmanagement submenu

* Apply Prettier formatting

* add comments

* Apply Prettier formatting

* Coworking session submenu updates

* Apply Prettier formatting

* finish workflows section

* Apply Prettier formatting

* web infra submenu

* Apply Prettier formatting

* more submenu work

* Apply Prettier formatting

* Add notes for merge blockers

* Apply Prettier formatting

* certification menu organizing

* Apply Prettier formatting

* updating links in header

* Apply Prettier formatting

* clean up a few links

* Cleaning up education section

* Apply Prettier formatting

* cleaning up support menu

* prettier

* more reordering in troubleshooting

* prettier

* getting header functioning with menu of links

* header cleanup

* top level menu fixes

* Apply Prettier formatting

* moving a guide

* Apply Prettier formatting

* reviewing pages to delete

* prettier

* removing unused import

* moving pages to delete

* bring back search bar

* Apply Prettier formatting

* removing popover code

* Apply Prettier formatting

* removing popover code

* Apply Prettier formatting

* fixing import order

* Apply Prettier formatting

* landing page layout

* landing page layout

* Apply Prettier formatting

* some comment cleanup

* whitespace

* cleaning up the drupal upgrade and migration stuff

* moving around links

* Apply Prettier formatting

* menu updates

* prettier

* updating all-written-paths.txt

* more menu updates

* prettier

* some cleanup

* redistributing landing pages

* prettier

* Adding search to landing page

* adding new pages to menu

* prettier

* Apply Prettier formatting

* Deleting the unassignedPages submenu

* redistributing some pages that were previously in "pages to delete"

* For easier review, reorder based on work done in pr #9335

* Apply Prettier formatting

* Finish pagestodelete submenu

* Apply Prettier formatting

* Delete all-written-paths.txt

* Update source/content/guides/drush/04-drupal-commandline.md

* removing todos that are done

* Update src/components/omniSidebarNav/submenus/support.js

* moving some reporting out of index

* prettier

* Apply suggestions from code review

* Apply Prettier formatting

* Terminus menu fix

* Apply Prettier formatting

---------

Co-authored-by: Chris Reynolds <chris.reynolds@pantheon.io>
Co-authored-by: Rachel Whitton <rachel@pantheon.io>
Co-authored-by: Pantheon Bot <bot@getpantheon.com>
Co-authored-by: Chris Reynolds <chris@jazzsequence.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site: Design Issues about the design of of the site, often regressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants