Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAN-2120: remove bid id #12

Merged

Conversation

juanmanuel-tirado
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

The Bid ID column has to be removed from the bid command output.

Related Tickets & Documents

NA

QA Instructions

Run locally to check that output is correctly displayed:

python -m pantos.cli bids ethereum ethereum
/Users/XXXX/pantos/pantos-client-cli/env/lib/python3.12/site-packages/cerberus/validator.py:1674: UserWarning: No validation schema is defined for the arguments of rule 'one_not_present'
  warn(
Pantos service node bids for token transfers from the
source blockchain ETHEREUM to the destination blockchain ETHEREUM:

Service node                                    Time    Fee
                                                (s)     (PAN)
=====================================================================
0x9AbdAFA5b582Bd0A8A891bCA152674bb51176DE9      450     0.35
0x3fE3384286A7419b67031A4b4f49249AEEB02e26      5       0.2
0x726265A9e352F2e9f15F255957840992803cED7d      600     1
0xE25f1945fC38238dE7E3a9ab7106E8856cb3Ed4f      600     1
0x8529866eA10ECE785bBD0CAa78fCC0DaC13EAF63      10      246.36
0x8529866eA10ECE785bBD0CAa78fCC0DaC13EAF63      600     215.56
0x8529866eA10ECE785bBD0CAa78fCC0DaC13EAF63      1200    184.76
0x9e359AFd56be06cA6f389D0C552dB15f6948C62F      30      12
0x9e359AFd56be06cA6f389D0C552dB15f6948C62F      240     0.8
0x9e359AFd56be06cA6f389D0C552dB15f6948C62F      800     4
0x3432DefF56c3d6e1883d0A5c8243c11dA01257c8      5000    0.1
0x3432DefF56c3d6e1883d0A5c8243c11dA01257c8      6000    4.321
0x3432DefF56c3d6e1883d0A5c8243c11dA01257c8      4       4.321

[optional] Are there any post deployment tasks we need to perform?

The warning message has to be addressed on a separate PR.

@juanmanuel-tirado juanmanuel-tirado self-assigned this Jul 30, 2024
@juanmanuel-tirado juanmanuel-tirado added the bug Something isn't working label Jul 30, 2024
@juanmanuel-tirado juanmanuel-tirado added this to the 1.1.3 milestone Jul 30, 2024
@juanmanuel-tirado juanmanuel-tirado merged commit dad7ba4 into pantos-io:main Jul 31, 2024
11 checks passed
@juanmanuel-tirado juanmanuel-tirado deleted the PAN-2120-remove-bid-id branch July 31, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

3 participants