Adding skills. See #23 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ioggstream
reviewed
May 7, 2024
Comment on lines
+43
to
+47
| @pytest.mark.parametrize( | ||
| "products,expected_results", | ||
| [({"ansible", "JBoss", "Bash"}, 3), ({"agile", "scrum", "kanban"}, 1)], | ||
| ) | ||
| def test_search_skill_label(db, products, expected_results): |
There was a problem hiding this comment.
Verify that both old and new skills are accessible, using a parametric test.
ioggstream
reviewed
May 7, 2024
| @@ -42,12 +47,16 @@ allowlist_externals = | |||
| sitepackages = True | |||
|
|
|||
| commands_pre = | |||
| python -m spacy download en_core_web_trf | |||
| # Eventually download en_core_web_trf. | |||
| python -c "import spacy; m='en_core_web_trf'; spacy.util.is_package(m) or spacy.cli.download(m)" | |||
There was a problem hiding this comment.
We download the model only if it's not already there. This saves a lot of time (and CO2)
ioggstream
reviewed
May 7, 2024
| # Eventually download en_core_web_trf. | ||
| python -c "import spacy; m='en_core_web_trf'; spacy.util.is_package(m) or spacy.cli.download(m)" | ||
| # Ensure sparql is populated. | ||
| pytest tests/test_sparql.py |
There was a problem hiding this comment.
Test if sparql is ok before rebuilding the model. If this fails, then the sparql server is not up and running.
ioggstream
reviewed
May 7, 2024
|
|
||
| commands = | ||
| python model/model.py | ||
| rm generated/output -fr | ||
| mkdir -p generated/output | ||
| pytest tests/test_localdb_base.py |
There was a problem hiding this comment.
after the build, we test that new skills are there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fix: #23 based on #27