Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PEP518 and Poetry instead requirements.txt and setuptools #26

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

henryx
Copy link

@henryx henryx commented Apr 7, 2023

Fixes issue #25

@henryx henryx changed the title Use PEP518 and Powtry instead requirements.txt and setuptools Use PEP518 and Poetry instead requirements.txt and setuptools Apr 7, 2023
@ioggstream
Copy link
Contributor

Can you separate the poetry stuff from the rest?

We need to investigate more before switching to poetry, since we had issues with it in the past.

@henryx
Copy link
Author

henryx commented Apr 7, 2023

No, because although PEP518 allows you to use other backends, the pyproject.toml has been configured to use Poetry

Copy link
Contributor

@ioggstream ioggstream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split the pyproject.toml and the poetry stuff?

"Operating System :: OS Independent",
]
[tool.poetry.dependencies]
python = "^3.11"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henryx We need to support at least py3.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants