Skip to content

Commit

Permalink
parent 59018bb
Browse files Browse the repository at this point in the history
author shamb0 <r.raajey@gmail.com> 1724476428 +0530
committer shamb0 <r.raajey@gmail.com> 1724952861 +0530

Refactor: Address review comments

Signed-off-by: shamb0 <r.raajey@gmail.com>
  • Loading branch information
shamb0 committed Aug 29, 2024
1 parent 59018bb commit f9a3eeb
Show file tree
Hide file tree
Showing 34 changed files with 7,815 additions and 502 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/lint-rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,6 @@ jobs:

- name: Run Clippy
run: cargo clippy --workspace --all-targets -- -D warnings --no-deps

- name: Dependency Check
run: cargo install cargo-machete && cargo machete
6 changes: 3 additions & 3 deletions .github/workflows/publish-github-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,15 @@ jobs:
--method PATCH \
-H "Accept: application/vnd.github+json" \
-H "X-GitHub-Api-Version: 2022-11-28" \
/repos/paradedb/paradedb/actions/variables/${{ steps.version.outputs.gha_var_name }} \
/repos/paradedb/pg_analytics/actions/variables/${{ steps.version.outputs.gha_var_name }} \
-f name='${{ steps.version.outputs.gha_var_name }}' \
-f value='${{ steps.version.outputs.gha_var_value }}'
gh api \
--method PATCH \
-H "Accept: application/vnd.github+json" \
-H "X-GitHub-Api-Version: 2022-11-28" \
/repos/paradedb/paradedb/actions/variables/VERSION_DEV_RC \
/repos/paradedb/pg_analytics/actions/variables/VERSION_DEV_RC \
-f name='VERSION_DEV_RC' \
-f value='0'
# on dev we only update dev RC
Expand All @@ -93,7 +93,7 @@ jobs:
--method PATCH \
-H "Accept: application/vnd.github+json" \
-H "X-GitHub-Api-Version: 2022-11-28" \
/repos/paradedb/paradedb/actions/variables/${{ steps.version.outputs.gha_var_name }} \
/repos/paradedb/pg_analytics/actions/variables/${{ steps.version.outputs.gha_var_name }} \
-f name='${{ steps.version.outputs.gha_var_name }}' \
-f value='${{ steps.version.outputs.gha_var_value }}'
else
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
.DS_Store

# Cargo
Cargo.lock
target/

# Rustfmt
Expand Down
Loading

0 comments on commit f9a3eeb

Please sign in to comment.