This repository was archived by the owner on Nov 25, 2024. It is now read-only.
chore(cli): use reth_cli_util allocator #137
Merged
+3
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-enhancement
mattsse
approved these changes
Oct 7, 2024
onbjerg
reviewed
Oct 7, 2024
bin/alphanet/Cargo.toml
Outdated
| @@ -30,7 +30,7 @@ default = ["jemalloc"] | |||
|
|
|||
| asm-keccak = ["reth-optimism-cli/asm-keccak"] | |||
|
|
|||
| jemalloc = ["dep:tikv-jemallocator"] | |||
| jemalloc = ["dep:tikv-jemallocator", "reth-cli-util/jemalloc"] | |||
There was a problem hiding this comment.
should we not remove the dep:tikv-jemallocator? it's pulled in by reth-cli-util/jemalloc
Rjected
force-pushed
the
dan/propagate-jemalloc-feature
branch
from
f24eedf to
21d5827
Compare
Rjected
force-pushed
the
dan/propagate-jemalloc-feature
branch
from
21d5827 to
b801609
Compare
onbjerg
approved these changes
Oct 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now uses the
reth_cli_utilallocator, instead of manually pulling in jemalloc