This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
feat: add AUTHCALL instruction #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
added
C-enhancement
fgimenez
force-pushed
the
fgimenez/authcall-instruction
branch
from
f778062 to
4d258ee
Compare
fgimenez
changed the base branch from
main
to
fgimenez/use-stateful-instruction-in-auth
fgimenez
force-pushed
the
fgimenez/authcall-instruction
branch
3 times, most recently
from
c280839 to
1bb9343
Compare
fgimenez
changed the base branch from
fgimenez/use-stateful-instruction-in-auth
to
main
fgimenez
force-pushed
the
fgimenez/authcall-instruction
branch
from
1bb9343 to
33dffda
Compare
fgimenez
force-pushed
the
fgimenez/authcall-instruction
branch
from
33dffda to
e162990
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards: #5
Implements
AUTHCALLas described in EIP-3074. The logic is mostly the same as in the regularCALL, but it checks for the context variableauthorized(set byAUTH) and, if present, is used as thecallerin the subsequent call.CALL's gas calculation requires a genericSPECargument, in order to provide it forAUTHCALLwe usespec_to_generic!, which sets it up using evm's Spec Id. For this to work I needed to properly setup theoptimismfeature for all the dependencies.