feat: validate headers loaded from file on reth import
#14050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
C-enhancement
joshieDo
requested review from
onbjerg,
rkrasiuk,
mattsse and
Rjected
as code owners
joshieDo
force-pushed
the
joshie/import-validation
branch
2 times, most recently
from
2fb92ca to
f187331
Compare
mattsse
requested changes
Jan 28, 2025
| @@ -668,7 +717,7 @@ mod tests { | |||
| let mut local_header = headers.first().unwrap().clone(); | |||
|
|
|||
| // test | |||
| while let Some(client) = reader.next_chunk::<FileClient>().await.unwrap() { | |||
| while let Some(client) = reader.next_chunk::<Block>(NoopConsensus::arc()).await.unwrap() { | |||
There was a problem hiding this comment.
this loops a bit odd, why do we need to provide this per chunk?
There was a problem hiding this comment.
although not ideal, each chunk is like 1GB worth of blocks that we read from disk, so it should be kinda fine
Comment on lines
+94
to
+95
| while let Some(file_client) = | ||
| reader.next_chunk::<BlockTy<N>>(consensus.clone(), Some(sealed_header)).await? |
There was a problem hiding this comment.
this works, but I wonder if a nicer solution to this would be a custom stream type and not require the consensus per next_chunk call.
but this entire type is weird so seems fine
There was a problem hiding this comment.
agree, would rather we track this separately tbh, just want it to work for now for hive tests
joshieDo
force-pushed
the
joshie/import-validation
branch
2 times, most recently
from
3b2de27 to
af41aba
Compare
mattsse
approved these changes
Jan 28, 2025
joshieDo
force-pushed
the
joshie/import-validation
branch
from
af41aba to
ad0a920
Compare
joshieDo
force-pushed
the
joshie/import-validation
branch
from
ad0a920 to
b2fdec7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were trusting that all headers coming from rlp were valid, but that might not be the case (eg. hive negative tests)
Should solve a bunch of tests on hive eest
#14009
edit: it does solve a bunch of eest tests (consume/rlp)