Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate block against header on reth import #14076

Merged
merged 3 commits into from
Jan 29, 2025
Merged

fix: validate block against header on reth import #14076

merged 3 commits into from
Jan 29, 2025

Conversation

joshieDo
Copy link
Collaborator

Validates the block against the header coming from reth import.

Fixes a bunch of eest tests on #14009

@joshieDo joshieDo requested a review from rkrasiuk January 29, 2025 19:41
@joshieDo joshieDo requested a review from onbjerg as a code owner January 29, 2025 19:41
@joshieDo joshieDo added C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test C-hivetest Used for labelling automated issues relating to hive test failures A-ci Related to github workflows or other build and lint tools and removed C-test A change that impacts how or what we test labels Jan 29, 2025
Rjected
Rjected approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/net/downloaders/src/file_client.rs Outdated Show resolved Hide resolved
@joshieDo joshieDo enabled auto-merge January 29, 2025 22:28
@joshieDo joshieDo added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 5a7e057 Jan 29, 2025
44 checks passed
@joshieDo joshieDo deleted the joshie/validate-block branch January 29, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Rjected approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-ci Related to github workflows or other build and lint tools C-bug An unexpected or incorrect behavior C-hivetest Used for labelling automated issues relating to hive test failures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshieDo @Rjected @mattsse