Move HashedPostState into trie-common crate #14219
Closed
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeerChaurasia
requested review from
rkrasiuk,
Rjected and
shekhirin
as code owners
mattsse
reviewed
Feb 4, 2025
Comment on lines
+15
to
+20
| pub struct HashedPostState { | ||
| /// Mapping of hashed address to account info, `None` if destroyed. | ||
| pub accounts: B256HashMap<Option<Account>>, | ||
| /// Mapping of hashed address to hashed storage. | ||
| pub storages: B256HashMap<HashedStorage>, | ||
| } |
There was a problem hiding this comment.
we want to move the entire file
perhaps state.rs -> hashedstate.rs?
There was a problem hiding this comment.
Yeah, I'm working on it and will soon raise a PR for it.
|
oh someone else also started on this #14230 perhaps you're interested in a different good first issue instead? please ping if you don't find anything |
|
yeah got it assigned!!Thankss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14208