Fix issue #14316. fix: prevent blocking on sparse trie drop #14331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VolodymyrBg
requested review from
rkrasiuk,
mattsse,
Rjected and
fgimenez
as code owners
emhane
added
C-perf
|
closing in favor of #14333 This also does not spawn the drop in a background task, and has multiple other unrelated changes that make some APIs less ergonomic (e.g. the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sparse trie drop operation was potentially blocking the main thread when
the trie was dropped. This change moves the trie drop operation into a
background task to prevent any blocking behavior.
Fixes #14316