Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add debug_chainConfig endpoint #14346

Merged
merged 2 commits into from
Feb 9, 2025
Merged

add debug_chainConfig endpoint #14346

merged 2 commits into from
Feb 9, 2025

Conversation

siosw
Copy link
Contributor

@siosw siosw commented Feb 9, 2025

closes #14344

@mattsse mattsse added the A-rpc Related to the RPC implementation label Feb 9, 2025
mattsse
mattsse requested changes Feb 9, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, ty

pedantic nits

crates/rpc/rpc/src/debug.rs Outdated Show resolved Hide resolved
crates/rpc/rpc/src/debug.rs Outdated Show resolved Hide resolved
@siosw siosw force-pushed the siosw/rpc-chain-config branch from c35e754 to 75b1389 Compare February 9, 2025 21:05
mattsse
mattsse approved these changes Feb 9, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice ty

@fgimenez I think we could try removing that op pin again

@mattsse mattsse enabled auto-merge February 9, 2025 22:16
@mattsse mattsse added this pull request to the merge queue Feb 9, 2025
Merged via the queue into paradigmxyz:main with commit 46d63e8 Feb 9, 2025
44 checks passed
@fgimenez
Copy link
Member

@fgimenez I think we could try removing that op pin again

@mattsse same error, the problem happens in an op-geth - op-node pair (which acts as sequencer afaik), I've verified that the debug API is enabled

18aaddy pushed a commit to 18aaddy/reth that referenced this pull request Feb 12, 2025
@siosw @18aaddy
add debug_chainConfig endpoint (paradigmxyz#14346)
e4772d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add debug_chainConfig in DebugApi
3 participants
@siosw @fgimenez @mattsse