feat: avoid zstd dependency in reth-evm, reth-evm-ethereum and reth-optimism-evm #14356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leruaa
requested review from
mattsse,
rakita,
Rjected,
fgimenez and
gakonst
as code owners
mattsse
reviewed
Feb 10, 2025
| @@ -15,10 +15,10 @@ workspace = true | |||
| reth-chainspec.workspace = true | |||
| reth-ethereum-forks.workspace = true | |||
| reth-evm.workspace = true | |||
| reth-primitives = { workspace = true, features = ["reth-codec"] } | |||
There was a problem hiding this comment.
isn't this change sufficient to remove zstd from the dep graph?
There was a problem hiding this comment.
Unfortunately no, we still have this:
➜ cargo tree -i zstd
zstd v0.13.2
├── reth-nippy-jar v1.1.5 (/home/aurel/dev/reth/crates/storage/nippy-jar)
│ └── reth-db v1.1.5 (/home/aurel/dev/reth/crates/storage/db)
│ ├── reth-storage-api v1.1.5 (/home/aurel/dev/reth/crates/storage/storage-api)
│ │ └── reth-revm v1.1.5 (/home/aurel/dev/reth/crates/revm)
│ │ ├── reth-evm v1.1.5 (/home/aurel/dev/reth/crates/evm)
│ │ │ ├── reth-evm-ethereum v1.1.5 (/home/aurel/dev/reth/crates/ethereum/evm)
│ │ │ │ ├── rsp-client-eth v0.0.0 (/home/aurel/dev/rsp/bin/client-eth)
│ │ │ │ └── rsp-client-executor v0.1.0 (/home/aurel/dev/rsp/crates/executor/client)
│ │ │ │ └── rsp-client-eth v0.0.0 (/home/aurel/dev/rsp/bin/client-eth)
│ │ │ ├── reth-optimism-evm v1.1.5 (/home/aurel/dev/reth/crates/optimism/evm)
│ │ │ │ └── rsp-client-executor v0.1.0 (/home/aurel/dev/rsp/crates/executor/client) (*)
│ │ │ └── rsp-client-executor v0.1.0 (/home/aurel/dev/rsp/crates/executor/client) (*)
│ │ ├── reth-evm-ethereum v1.1.5 (/home/aurel/dev/reth/crates/ethereum/evm) (*)
│ │ └── reth-optimism-evm v1.1.5 (/home/aurel/dev/reth/crates/optimism/evm) (*)
│ └── reth-trie-db v1.1.5 (/home/aurel/dev/reth/crates/trie/db)
│ └── reth-storage-api v1.1.5 (/home/aurel/dev/reth/crates/storage/storage-api) (*)
└── reth-zstd-compressors v1.1.5 (/home/aurel/dev/reth/crates/storage/zstd-compressors)
└── reth-ethereum-primitives v1.1.5 (/home/aurel/dev/reth/crates/ethereum/primitives)
├── reth-primitives v1.1.5 (/home/aurel/dev/reth/crates/primitives)
│ ├── reth-db v1.1.5 (/home/aurel/dev/reth/crates/storage/db) (*)
│ ├── reth-db-api v1.1.5 (/home/aurel/dev/reth/crates/storage/db-api)
│ │ ├── reth-db v1.1.5 (/home/aurel/dev/reth/crates/storage/db) (*)
│ │ ├── reth-storage-api v1.1.5 (/home/aurel/dev/reth/crates/storage/storage-api) (*)
│ │ └── reth-trie-db v1.1.5 (/home/aurel/dev/reth/crates/trie/db) (*)
│ ├── reth-ethereum-consensus v1.1.5 (/home/aurel/dev/reth/crates/ethereum/consensus)
│ │ ├── reth-evm-ethereum v1.1.5 (/home/aurel/dev/reth/crates/ethereum/evm) (*)
│ │ └── rsp-client-executor v0.1.0 (/home/aurel/dev/rsp/crates/executor/client) (*)
│ ├── reth-evm v1.1.5 (/home/aurel/dev/reth/crates/evm) (*)
│ ├── reth-evm-ethereum v1.1.5 (/home/aurel/dev/reth/crates/ethereum/evm) (*)
│ ├── reth-execution-types v1.1.5 (/home/aurel/dev/reth/crates/evm/execution-types)
│ │ ├── reth-evm v1.1.5 (/home/aurel/dev/reth/crates/evm) (*)
│ │ ├── reth-optimism-evm v1.1.5 (/home/aurel/dev/reth/crates/optimism/evm) (*)
│ │ ├── reth-storage-api v1.1.5 (/home/aurel/dev/reth/crates/storage/storage-api) (*)
│ │ ├── rsp-client-executor v0.1.0 (/home/aurel/dev/rsp/crates/executor/client) (*)
│ │ └── rsp-mpt v0.1.0 (/home/aurel/dev/rsp/crates/mpt)
│ │ └── rsp-client-executor v0.1.0 (/home/aurel/dev/rsp/crates/executor/client) (*)
│ ├── reth-optimism-consensus v1.1.5 (/home/aurel/dev/reth/crates/optimism/consensus)
│ │ ├── reth-optimism-evm v1.1.5 (/home/aurel/dev/reth/crates/optimism/evm) (*)
│ │ └── rsp-client-executor v0.1.0 (/home/aurel/dev/rsp/crates/executor/client) (*)
│ ├── reth-optimism-evm v1.1.5 (/home/aurel/dev/reth/crates/optimism/evm) (*)
│ ├── reth-storage-api v1.1.5 (/home/aurel/dev/reth/crates/storage/storage-api) (*)
│ ├── rsp-client-eth v0.0.0 (/home/aurel/dev/rsp/bin/client-eth)
│ ├── rsp-client-executor v0.1.0 (/home/aurel/dev/rsp/crates/executor/client) (*)
│ ├── rsp-mpt v0.1.0 (/home/aurel/dev/rsp/crates/mpt) (*)
│ ├── rsp-primitives v0.1.0 (/home/aurel/dev/rsp/crates/primitives)
│ │ ├── rsp-client-eth v0.0.0 (/home/aurel/dev/rsp/bin/client-eth)
│ │ ├── rsp-mpt v0.1.0 (/home/aurel/dev/rsp/crates/mpt) (*)
│ │ └── rsp-witness-db v0.1.0 (/home/aurel/dev/rsp/crates/storage/witness-db)
│ │ └── rsp-client-executor v0.1.0 (/home/aurel/dev/rsp/crates/executor/client) (*)
│ └── rsp-witness-db v0.1.0 (/home/aurel/dev/rsp/crates/storage/witness-db) (*)
├── reth-revm v1.1.5 (/home/aurel/dev/reth/crates/revm) (*)
└── rsp-client-executor v0.1.0 (/home/aurel/dev/rsp/crates/executor/client) (*)
There was a problem hiding this comment.
ah that's annyoing, the storage-api depends on trie-db which pulls in the entire db stuff...
will work on that separately
mattsse
approved these changes
Feb 10, 2025
klkvr
approved these changes
Feb 10, 2025
mattsse
added
the
A-dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently working on updating the Reth dependency in RSP, but this time, I want RSP to depend on upstream Reth directly instead of a patched fork.
So, I need to avoid
zstdbeing loaded in the dependency graph because it doesn't compile in SP1. And I think the easiest way to do that is to cut thereth-revmdependency inreth-evm,reth-evm-ethereumandreth-optimism-evm.Turns out most of the types from
reth-revmwere re-export fromrevm, with the exception of the batch module, that I had to move toreth-evm.I also had to remove
reth-primitives"reth-codec" feature inreth-evm, but it don't seems to be used.