feat(examples): Implement missing node components in custom-node example #16343
Conversation
…ample So that the `ComponentBuilder` with components from `custom-node` satisfies `NodeComponentBuilder`
…custom_node` example
…ll the trait impls Extract inner header for `BlockAssembler` expecting Optimism block header
…tion<CustomTxEnv>` Even when `CustomTxEnv` implements `FromRecoveredTx` and `FromEncodedTx`, the `OpTransaction<CustomTxEnv>` does not.
| @@ -19,11 +19,126 @@ reth-rpc-api.workspace = true | |||
| reth-rpc-engine-api.workspace = true | |||
| reth-ethereum = { workspace = true, features = ["node-api", "network", "evm", "pool"] } | |||
|
|
|||
| reth-basic-payload-builder.workspace = true | |||
There was a problem hiding this comment.
since we intend this to be a blueprint, we should cleanup deps here, let's try to pull in as much as possible from reth-ethereum L20 and add missing re-exports
so ideally none of these imports are necessary
| use std::sync::Arc; | ||
|
|
||
| pub struct CustomTxEnv(TxEnv); |
There was a problem hiding this comment.
I think we could possible even reuse the existing texenv entire for the payment tx type, but let's do the full example like this
| #[derive(Clone, Debug)] | ||
| pub(crate) struct CustomTxPriority { | ||
| chain_id: ChainId, | ||
| } |
There was a problem hiding this comment.
do we even need this @klkvr ?
There was a problem hiding this comment.
yeah I think we can reuse the OpPayloadTransactions here for now
| pub(crate) fn from(value: OpTxEnvelope) -> CustomTransaction { | ||
| Extended::BuiltIn(value) | ||
| } |
There was a problem hiding this comment.
we could just make this From impls in the reth-primitives-traits?
because the expectation is that these are always used as the BuiltIn variants?
RomanHodulak
force-pushed
the
custom-node-impls
branch
from
902e932 to
bc159b7
Compare
…or `CustomTxEnv` of `Other` variant
| @@ -1,15 +1,24 @@ | |||
| use crate::chainspec::CustomChainSpec; | |||
| use alloy_consensus::{Block, Header}; | |||
| use crate::{ | |||
There was a problem hiding this comment.
we're defining 2 custom txenvs here — CustomTxEnv and CustomEvmTransaction, do we need both?
No description provided.