fix(cli): allow disabling invalid block hooks by removing default “witness” #18918
+6
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashass1315
requested review from
Rjected,
gakonst,
klkvr and
mattsse
as code owners
yes, we need the witness hook on by default, otherwise the chance of getting that data for debugging on a bad block is very low |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The --debug.invalid-block-hook flag used default_value = "witness" with Option<_>, which always parsed as Some(Witness). This made the None branch (installing NoopInvalidBlockHook) unreachable via CLI, so users couldn’t disable hooks.
Solution: Removed the clap default for --debug.invalid-block-hook and set DebugArgs::default().invalid_block_hook = None. Updated tests to expect None by default and amended CLI docs to state hooks are disabled by default.
Impact: Omitting the flag now disables invalid block hooks; users must pass the flag to enable hooks (e.g., --debug.invalid-block-hook witness).