fix(storage/libmdbx-rs): avoid panic in read tx monitor by using saturating_sub #18938
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Oct 14, 2025
|
|
||
| // Sleep not more than `READ_TRANSACTIONS_CHECK_INTERVAL`, but at least until | ||
| // the closest deadline of an active read transaction | ||
| // Use saturating_sub to avoid panic when active duration exceeds max_duration |
There was a problem hiding this comment.
you guys need to stop writing comments like this
this has 0 benefit without the pr as context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Durationsubtraction withsaturating_subwhen computingsleep_duration.Duration - Durationpanics on negative results; long‑lived read txs could crash the monitor thread.crates/storage/libmdbx-rs/src/txn_manager.rs(read_transactions::start_monitor), compute:READ_TRANSACTIONS_CHECK_INTERVAL.min(self.max_duration.saturating_sub(max_active_transaction_duration.unwrap_or_default())).