Skip to content

feat: allow using SafeNoSync for MDBX #18945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: allow using SafeNoSync for MDBX #18945

wants to merge 3 commits into from

Conversation

eabz
Copy link

@eabz eabz commented Oct 11, 2025 •
edited
Loading

This PR introduces a flag to enable to users to initialize the database with SafeNoSync mode.

Fixes: #18565

Introduces:

  • Added a new element sync_mode to the DatabaseArguments and DatabaseArgs.
  • Added a TypedParser to make sure only Durable and SafeNoSync options are used.
  • Passes the variable to DatabaseArguments::new function.
  • Changed all the tests where DatabaseArguments::new is used to use the SafeNoSync mode.
  • Hardcodes the usage in stage/dump to Durable.
  • Argument defaults to Durable

Can you point me if the documentation update is necessary?

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Oct 11, 2025
@eabz eabz changed the title feat: allow using SafeNoSync for MDBX database feat: allow using SafeNoSync for MDBX Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

1 more reviewer

@fynnss fynnss fynnss approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

Reth Tracker
Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

allow using SafeNoSync for mdbx to increase write performance

2 participants

@eabz @fynnss