feat(cli): Reuse a single StaticFileProducer across file import chunks #18964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarmashAlex
requested review from
Rjected,
fgimenez and
mattsse
as code owners
mattsse
requested changes
Oct 17, 2025
| .sealed_header(provider_factory.last_block_number()?)? | ||
| .expect("should have genesis"); | ||
|
|
||
| // Reuse a single StaticFileProducer across all chunks |
There was a problem hiding this comment.
please dont add comments like pr descriptions
these are totally useless without the pr context
joshieDo
approved these changes
Oct 17, 2025
mattsse
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, each file-import chunk created a new StaticFileProducer and passed it into a freshly built pipeline. StaticFileProducer is a lightweight Arc<Mutex<...>> wrapper with no chunk-specific state and is safe to clone and reuse. Creating it per chunk caused unnecessary allocations and event-channel setups without any functional benefit.
This change creates one StaticFileProducer before the import loop and passes static_file_producer.clone() into each pipeline build. It aligns the import path with the node’s engine lifecycle (where a single producer is reused), reduces overhead, and preserves behavior.