Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add toaster & custom toast components #68

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

b4s36t4
Copy link
Contributor

@b4s36t4 b4s36t4 commented Sep 16, 2023

#58

Introducing react-hot-toast package to the repo helping us show indicator wherever needed.

Ex: #59

Screenshots

Error

Screenshot 2023-09-16 at 8 35 56 PM

Success

Screenshot 2023-09-16 at 8 35 48 PM

Loading

Screenshot 2023-09-16 at 8 35 20 PM

All of the demos share same message, so please ignore the message 🥇

@b4s36t4
Copy link
Contributor Author

b4s36t4 commented Sep 16, 2023

Maybe code is too duplicated or so, we can reduce but for readability and understanding purposes I wrote things in different files/components.

@jxom
Copy link
Member

jxom commented Sep 18, 2023

Thanks for the PR! Was testing out react-hot-toast and ended up migrating to sonner. I feel like the collapsed stacking on sonner is a lot less intrusive than hot toast! Either way, you're contribution still means a lot!

@jxom jxom merged commit c3f4c92 into paradigmxyz:main Sep 18, 2023
3 of 4 checks passed
@b4s36t4 b4s36t4 deleted the feat/add-toast branch September 18, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants