feat/safely add the support of having HTTP w/ self-signed SSL#13
Open
pinotelio wants to merge 1 commit intoparadixe:mainfrom
Open
feat/safely add the support of having HTTP w/ self-signed SSL#13pinotelio wants to merge 1 commit intoparadixe:mainfrom
pinotelio wants to merge 1 commit intoparadixe:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview of this PR
ENABLE_HTTPSenvironment variable (maintained the current behaviour and defaulting the wizard setup toHTTPand current behaviour).curlcommands and the user outputs based on the HTTP/HTTPS conditionsTests ✅
Here are the self-signed settings test results:
Setup Wizard ☝
Setup Wizard Output ☝
Successful Node Registration ☝
Verified Registered Node in the Dashboard ☝
Deployments Note
dashboardcontainer images and temporarily comment out some sections in the setup scripts, so that the scripts point to my own custom image instead of the production image. That being said, if all goes well and the PR gets merged,ghcr.io/paradixe/conduit-dashboard:latestneeds to be built with the latest changes and pushed, to make this feature work.@paradixe
Please feel free give a it a look and additional tests if needed
❤️ 🕊️✌️