Skip to content

Adds building and testing of examples to CI. #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Superhepper wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adds building and testing of examples to CI. #599

Superhepper wants to merge 1 commit into from

Conversation

@Superhepper
Copy link
Collaborator

@Superhepper Superhepper commented Nov 22, 2025 •
edited
Loading

Fixes #467

@Superhepper Superhepper marked this pull request as ready for review November 23, 2025 21:09
wiktor-k
wiktor-k reviewed Nov 24, 2025
View reviewed changes
@Superhepper Superhepper force-pushed the Ci-Examples branch 5 times, most recently from 5cfecc7 to e1fd179 Compare November 24, 2025 21:09
@Superhepper Superhepper marked this pull request as draft November 24, 2025 21:20
@Superhepper Superhepper force-pushed the Ci-Examples branch 17 times, most recently from f63f15e to 0186912 Compare November 30, 2025 08:03
@Superhepper Superhepper force-pushed the Ci-Examples branch 4 times, most recently from 02fb471 to 7d4c6c5 Compare November 30, 2025 09:37
@Superhepper
Copy link
Collaborator Author

Superhepper commented Nov 30, 2025

@Firstyear

When I try to add the certify example as well I get an error I have not yet figured out.

thread 'main' panicked at tss-esapi/examples/certify.rs:385:10:
called `Result::unwrap()` on an `Err` value: TssError(Tpm(FormatOne(TpmFormatOneResponseCode { error_number: PolicyFail, argument_number: Session(2) })))

Is that something you have seen as well and have had any experience with?

@Superhepper Superhepper marked this pull request as ready for review December 3, 2025 21:15
ionut-arm
ionut-arm previously approved these changes Dec 4, 2025
View reviewed changes
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀
We can leave certify for a subsequent PR

@Superhepper
Adds building and testing of examples to CI.
78388bd 
Signed-off-by: Jesper Brynolf <jesper.brynolf@gmail.com>
@Superhepper
Copy link
Collaborator Author

Superhepper commented Dec 4, 2025

Yeah

@Superhepper Superhepper requested a review from wiktor-k December 7, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ionut-arm ionut-arm ionut-arm left review comments

@Firstyear Firstyear Awaiting requested review from Firstyear

@hug-dev hug-dev Awaiting requested review from hug-dev

@wiktor-k wiktor-k Awaiting requested review from wiktor-k

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add CI job for examples

3 participants

@Superhepper @wiktor-k @ionut-arm