Test/gradients #302
Merged
Test/gradients #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al=unbound' option to radialGradient; Gradient TotalStops field now reports the correct value
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // II. Distance Transform | ||
| // Create Float Buffer + 0 vs infinity (1e20) assignment | ||
| std::vector<double> image(width * height); |
Check failure
Code scanning / CodeQL
Multiplication result converted to larger type High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 14 days ago
To fix the problem, we need to ensure that the multiplication is performed using a larger integer type to prevent overflow. We can achieve this by casting one of the operands to size_type before performing the multiplication. This will ensure that the multiplication is done using the larger type, and the result will be correctly converted to size_type.
- Cast one of the operands (
widthorheight) tosize_typebefore performing the multiplication. - Update the initialization of the
std::vector<double>to use the result of the multiplication with the cast.
Suggested changeset
1
src/vector/agg/include/agg_span_gradient_contour.h
| @@ -140,3 +140,3 @@ | ||
| // Create Float Buffer + 0 vs infinity (1e20) assignment | ||
| std::vector<double> image(width * height); | ||
| std::vector<double> image(static_cast<std::vector<double>::size_type>(width) * height); | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.