Test/gradients #303
Merged
Test/gradients #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calculations; Fixed PNG palette saving
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| m_buffer.resize(size); | ||
| memset(m_buffer.data(), 255, size); | ||
| m_buffer.resize(width * height); |
Check failure
Code scanning / CodeQL
Multiplication result converted to larger type High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 17 days ago
To fix the problem, we need to ensure that the multiplication is performed using a larger integer type to prevent overflow. This can be achieved by casting one of the operands to size_t before performing the multiplication. This way, the multiplication will be done in the larger type, and the result will be correctly interpreted as a size_t.
- Cast one of the operands (
widthorheight) tosize_tbefore the multiplication. - Update the line where the multiplication occurs to ensure the correct type is used.
Suggested changeset
1
src/vector/agg/include/agg_span_gradient_contour.h
| @@ -109,3 +109,3 @@ | ||
|
|
||
| m_buffer.resize(width * height); | ||
| m_buffer.resize(static_cast<size_t>(width) * height); | ||
| std::fill(m_buffer.begin(), m_buffer.end(), 255); |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.