oomprof: prefer GNU build IDs for profiles#3168
Open
officialasishkumar wants to merge 1 commit intoparca-dev:mainfrom
Open
oomprof: prefer GNU build IDs for profiles#3168officialasishkumar wants to merge 1 commit intoparca-dev:mainfrom
officialasishkumar wants to merge 1 commit intoparca-dev:mainfrom
Conversation
OOMProf can capture Go build IDs with a trailing NUL byte when reading ELF notes directly. Passing those IDs through profile metadata makes Parca construct invalid cache paths during symbolization. Resolve OOMProf mappings through the executable's GNU build ID when the file is still available, and otherwise fall back to a NUL-trimmed captured ID. This applies to both raw OOM profiles and reporter-converted memory samples. Fixes parca-dev#3152
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OOMProf can capture Go build IDs with a trailing NUL byte when reading ELF notes directly. Passing those IDs through profile metadata makes Parca construct invalid cache paths during symbolization.
This resolves OOMProf mappings through the executable's GNU build ID when the file is still available, and otherwise falls back to a NUL-trimmed captured build ID. The same normalization is applied to raw OOM profiles and reporter-converted memory samples.
Fixes #3152
Tests: