Fix missing bin link for namespaced links

parcel-bundler · Jan 20, 2023 · cf226fb · cf226fb
1 parent ab0a470
commit cf226fb
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 9 deletions.
diff --git a/packages/core/integration-tests/test/parcel-link.js b/packages/core/integration-tests/test/parcel-link.js
@@ -212,6 +212,7 @@ describe('@parcel/link', () => {
       let fs = await createFS('/app')`
         yarn.lock:
         node_modules
+          .bin/parcel:
           @namespace
             parcel
             parcel-core`;
@@ -221,6 +222,11 @@ describe('@parcel/link', () => {
 
       assert(fs.existsSync('.parcel-link'));
 
+      assert.equal(
+        fs.realpathSync('node_modules/.bin/parcel'),
+        path.resolve(__dirname, '../../parcel/src/bin.js'),
+      );
+
       assert.equal(
         fs.realpathSync('node_modules/@namespace/parcel-core'),
         path.resolve(__dirname, '../../core'),

diff --git a/packages/dev/parcel-link/src/link.js b/packages/dev/parcel-link/src/link.js
@@ -6,6 +6,7 @@ import type {CmdOptions} from './utils';
 import {
   findParcelPackages,
   mapNamespacePackageAliases,
+  cleanupBin,
   cleanupNodeModules,
   fsWrite,
   fsSymlink,
@@ -40,6 +41,7 @@ export async function link(
   // --------------------------------------------------------------------------------
 
   for (let nodeModules of nodeModulesPaths) {
+    await cleanupBin(nodeModules, opts);
     await cleanupNodeModules(
       nodeModules,
       packageName => parcelPackages.has(packageName),

diff --git a/packages/dev/parcel-link/src/unlink.js b/packages/dev/parcel-link/src/unlink.js
@@ -4,6 +4,7 @@ import type {ParcelLinkConfig} from './ParcelLinkConfig';
 import type {CmdOptions} from './utils';
 
 import {
+  cleanupBin,
   cleanupNodeModules,
   execSync,
   findParcelPackages,
@@ -41,6 +42,7 @@ export async function unlink(
   // --------------------------------------------------------------------------------
 
   for (let nodeModules of nodeModulesPaths) {
+    await cleanupBin(nodeModules, opts);
     await cleanupNodeModules(
       nodeModules,
       packageName => parcelPackages.has(packageName),

diff --git a/packages/dev/parcel-link/src/utils.js b/packages/dev/parcel-link/src/utils.js
@@ -101,23 +101,25 @@ export function mapNamespacePackageAliases(
   return aliasesToParcelPackages;
 }
 
+export async function cleanupBin(root: string, opts: CmdOptions) {
+  let {fs} = opts;
+  let binSymlink = path.join(root, '.bin/parcel');
+  try {
+    await fsDelete(binSymlink, opts);
+  } catch (e) {
+    // noop
+  }
+}
+
 export async function cleanupNodeModules(
   root: string,
   predicate: (filepath: string) => boolean,
   opts: CmdOptions,
 ): Promise<void> {
   let {fs} = opts;
   for (let dirName of fs.readdirSync(root)) {
+    if (dirName === '.bin') continue;
     let dirPath = path.join(root, dirName);
-    if (dirName === '.bin') {
-      let binSymlink = path.join(root, '.bin/parcel');
-      try {
-        await fsDelete(binSymlink, opts);
-      } catch (e) {
-        // noop
-      }
-      continue;
-    }
     if (dirName[0].startsWith('@')) {
       await cleanupNodeModules(dirPath, predicate, opts);
       continue;