Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parcel-link and parcel-unlink dev CLIs #8618

Merged
merged 61 commits into from
Nov 3, 2023
Merged

Add parcel-link and parcel-unlink dev CLIs #8618

merged 61 commits into from
Nov 3, 2023

Commits on Nov 2, 2023

  1. Link script

    @mischnic @lettertwo
    mischnic authored and lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    1cb67df View commit details
    Browse the repository at this point in the history

  2. Lint

    @mischnic @lettertwo
    mischnic authored and lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    ba311de View commit details
    Browse the repository at this point in the history

  3. Scaffold atlassian-parcel-link package

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    2d2a040 View commit details
    Browse the repository at this point in the history

  4. Make link and unlink executable

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    f1abc6b View commit details
    Browse the repository at this point in the history

  5. Move binaries from src/ to bin/

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    cfbd3d5 View commit details
    Browse the repository at this point in the history

  6. Parse args and scaffold logging

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    bfcdadd View commit details
    Browse the repository at this point in the history

  7. Factor in original link implementation

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    29066d0 View commit details
    Browse the repository at this point in the history

  8. Extract mapAtlassianPackageAliases util

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    ed88188 View commit details
    Browse the repository at this point in the history

  9. Use log, not console.log

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    87fc3fb View commit details
    Browse the repository at this point in the history

  10. Implement unlink

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    7dc338d View commit details
    Browse the repository at this point in the history

  11. Export link and unlink from module 

    I guess in case they would be useful in another script...
    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    b59ea01 View commit details
    Browse the repository at this point in the history

  12. Allow configuration of the packageRoot for linking

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    35acbfa View commit details
    Browse the repository at this point in the history

  13. Force install after unlink

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    caf2182 View commit details
    Browse the repository at this point in the history

  14. Parametrize the namespace and node_modules globs 

    This gets us a step closer to a more generic solution
that can be published publicly by replacing all explicit
references to the "@atlassian" namespace.
    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    e888f2f View commit details
    Browse the repository at this point in the history

  15. Improve namespaced config rewrites 

    This should both expand to capture any entries
in the root package.json that configure a namespaced package
while also avoiding rewriting dependencies.
    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    fbd0ac4 View commit details
    Browse the repository at this point in the history

  16. Add namespace and nodeModulesGlobs options 

    This makes it so that the default behavior of link/unlink
works for @parcel packages in any standard Parcel project,
but allow configuring custom package namespace (e.g., for
forks of Parcel) and custom node_modules locations for
more complex setups.
    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    b98d2e9 View commit details
    Browse the repository at this point in the history

  17. Remove references to atlassian from parcel-link

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    11a95b6 View commit details
    Browse the repository at this point in the history

  18. Update README

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    df7b7cb View commit details
    Browse the repository at this point in the history

  19. Fix multi option parsing

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    8fb6335 View commit details
    Browse the repository at this point in the history

  20. Fix unlink arguments

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    d38502b View commit details
    Browse the repository at this point in the history

  21. Unify CLI and create submcommands 

    `link` is the default subcommand and can be omitted,
so `parcel-link [packageRoot]` still works.

Now, unlinking is done via subcommand:
`parcel-link unlink`
    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    c0bfea7 View commit details
    Browse the repository at this point in the history

  22. Lint/nits

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    24fab60 View commit details
    Browse the repository at this point in the history

  23. Extract ParcelLinkConfig

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    d479a38 View commit details
    Browse the repository at this point in the history

  24. Extract command to factory

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    6190315 View commit details
    Browse the repository at this point in the history

  25. Interface with @parcel/fs

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    f327589 View commit details
    Browse the repository at this point in the history

  26. Fix default command

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    5d3cf66 View commit details
    Browse the repository at this point in the history

  27. Make command configurable

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    0ed0e63 View commit details
    Browse the repository at this point in the history

  28. [WIP] tests

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    b9dd405 View commit details
    Browse the repository at this point in the history

  29. Throw instead of exit

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    ecf2c0a View commit details
    Browse the repository at this point in the history

  30. Improve app root detection

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    2fbae2b View commit details
    Browse the repository at this point in the history

  31. toJSON not toJson

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    e865380 View commit details
    Browse the repository at this point in the history

  32. Validate fs operations before performing them 

    This is really meant to avoid logging actions that actually sliently
fail, like trying to remove a file that doesn't exist.
    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    9f2f6c6 View commit details
    Browse the repository at this point in the history

  33. Add createFS test util

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    16823a2 View commit details
    Browse the repository at this point in the history

  34. Improve logged messages

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    328d0d7 View commit details
    Browse the repository at this point in the history

  35. Naming nit

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    532db00 View commit details
    Browse the repository at this point in the history

  36. Add descriptive error messages

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    640d32d View commit details
    Browse the repository at this point in the history

  37. Rename parcel-link util to utils 

    utils is the convention in the monorepo
    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    9e99a6b View commit details
    Browse the repository at this point in the history

  38. Lint

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    6db7152 View commit details
    Browse the repository at this point in the history

  39. Use globSync from @parcel/utils 

    More testable
    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    c624564 View commit details
    Browse the repository at this point in the history

  40. Use withFileTypes readdir option

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    f37f967 View commit details
    Browse the repository at this point in the history

  41. Use CopyOnWriteToMemoryFS in tests

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    fe12b7b View commit details
    Browse the repository at this point in the history

  42. Use OverlayFS in tests

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    c5a5023 View commit details
    Browse the repository at this point in the history

  43. Reverse direction of symlink message

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    d059736 View commit details
    Browse the repository at this point in the history

  44. Add tests for link with default and common options

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    ee89a69 View commit details
    Browse the repository at this point in the history

  45. Add tests, fixes for linking with a custom namespace

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    41e4ad0 View commit details
    Browse the repository at this point in the history

  46. Add tests, fixes for custom node_modules globs

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    015fc92 View commit details
    Browse the repository at this point in the history

  47. Remove old unlink options

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    1356e3e View commit details
    Browse the repository at this point in the history

  48. Fix link --dry-run

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    42590a8 View commit details
    Browse the repository at this point in the history

  49. Add unlink tests

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    40a3dcc View commit details
    Browse the repository at this point in the history

  50. Use fsFixture in parcel-link tests

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    4fa793b View commit details
    Browse the repository at this point in the history

  51. Fix missing bin link for namespaced links

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    ad2e0c0 View commit details
    Browse the repository at this point in the history

  52. Update version

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    6d0782e View commit details
    Browse the repository at this point in the history

  53. lint

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    89e1e76 View commit details
    Browse the repository at this point in the history

  54. Fix package versions

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    8adda2a View commit details
    Browse the repository at this point in the history

  55. Fix parcel-link tests

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    59f6762 View commit details
    Browse the repository at this point in the history

  56. Extract link and unlink commands

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    00a598f View commit details
    Browse the repository at this point in the history

  57. Update @babel/core dep

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    bb0cf6f View commit details
    Browse the repository at this point in the history

  58. Update readme

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    f93d2a2 View commit details
    Browse the repository at this point in the history

  59. Fix parcel-link tests

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    bd84525 View commit details
    Browse the repository at this point in the history

  60. skip tests failing on windows 

    these tests are for the '--namespace' feature,
which is is only useful if you're testing a fork of Parcel,
so seems safe enough to skip.
    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    7e75d92 View commit details
    Browse the repository at this point in the history

  61. Fix package versions

    @lettertwo
    lettertwo committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    dc1d820 View commit details
    Browse the repository at this point in the history