Create Parcel V3 javascript integration test suite #9886
Merged
+6,125
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonicaOlejniczak
approved these changes
Aug 1, 2024
|
Wouldn't it be easier to work on a branch instead of copying files? Or maybe add a function to conditionally skip tests based on a feature flag. Otherwise whenever we make changes to the tests we'll have to do it in two places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR copies the javascript integration test suite, running all the tests with the
parcelV3feature flag enabled. Eventually we should probably run the entire suite with the flag enabled but while we're so early it's a bit easier to keep things simple.Let's remove the skips as we fix the tests 👍