Fix MUSL canary builds #9894
Merged
Fix MUSL canary builds #9894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the issue comes from https://github.com/EmbarkStudios/crash-handling crates not compiling on MUSL. |
JakeLane
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MUSL canary builds by removing crash-reporting functionality from MUSL targets.
The reason why crash-reporting isn't working is not fully understood but relates to how crash-handler is implemented interposing the
pthread_createvalue. https://github.com/EmbarkStudios/crash-handling/blob/e1f1241580d5204880fa47802b867b6bcb975f98/crash-handler/src/unix/pthread_interpose.rs#L36-L41crash-reportinghas been added as a part of #9892 and will only target canary releases at this point.