feat: Add Persistent Cache Layer #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fia0
force-pushed
the
feature/pmap-cache
branch
8 times, most recently
from
dae7dda
to
22f87e9
Compare
fia0
force-pushed
the
feature/pmap-cache
branch
3 times, most recently
from
338dc4b
to
c9bbe43
Compare
fia0
force-pushed
the
feature/pmap-cache
branch
4 times, most recently
from
f46cc30
to
f270e06
Compare
fia0
force-pushed
the
feature/pmap-cache
branch
2 times, most recently
from
c00342b
to
c111ae9
Compare
This commit lifts the requirement for the pmap crate to the nightly toolchain. This applies transitively to the whole project when compiled with the nvm feature.
fia0
force-pushed
the
feature/pmap-cache
branch
2 times, most recently
from
905dfdc
to
f727205
Compare
fia0
force-pushed
the
feature/pmap-cache
branch
15 times, most recently
from
acf1028
to
f883a59
Compare
fia0
force-pushed
the
feature/pmap-cache
branch
3 times, most recently
from
48c201a
to
d82f950
Compare
This commit started with some bug tracking and lead to many fixes in performances which delivers an improvement of about 8-9x when using the persistent cache. Because some of the changes started intermittent of one another unravelling single proper commits is tedious and will likely not done. 御免.
fia0
force-pushed
the
feature/pmap-cache
branch
from
f4a7895
to
e635b6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a persistent hashmap which is used internally to store often read values.