Skip to content

Conversation

@alindima
Copy link

Fixes the circle test hangs from our scc-testing repo.
Depends on paritytech/polkadot-sdk#10387.

Also adds a test for setting the balance of and impersonating a contract account, as well as sending a transaction from a contract account.

Small misc change: increase the default capacity of the storage overrides LRU and make it configurable via CLI.

Copy link

@iulianbarbu iulianbarbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!


let charleth = Account::from(subxt_signer::eth::dev::charleth());
let tx = TransactionRequest::default()
.value(U256::from(2e18))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: capture 2e18 in a variable, and use it when asserting on the expected balance

github-merge-queue bot pushed a commit to paritytech/polkadot-sdk that referenced this pull request Nov 24, 2025
Only works for contract accounts, not precompiles.
This is needed so that test nodes like anvil can send transactions from
contract accounts, a widely-used feature in tests

Needed for paritytech/foundry-polkadot#423
github-merge-queue bot pushed a commit to paritytech/polkadot-sdk that referenced this pull request Nov 24, 2025
Only works for contract accounts, not precompiles.
This is needed so that test nodes like anvil can send transactions from
contract accounts, a widely-used feature in tests

Needed for paritytech/foundry-polkadot#423
github-merge-queue bot pushed a commit to paritytech/polkadot-sdk that referenced this pull request Nov 24, 2025
Only works for contract accounts, not precompiles.
This is needed so that test nodes like anvil can send transactions from
contract accounts, a widely-used feature in tests

Needed for paritytech/foundry-polkadot#423
github-merge-queue bot pushed a commit to paritytech/polkadot-sdk that referenced this pull request Nov 24, 2025
Only works for contract accounts, not precompiles.
This is needed so that test nodes like anvil can send transactions from
contract accounts, a widely-used feature in tests

Needed for paritytech/foundry-polkadot#423
Copy link

@re-gius re-gius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alindima alindima enabled auto-merge (squash) November 24, 2025 16:13
@alindima alindima merged commit 893a985 into master Nov 25, 2025
49 of 90 checks passed
@alindima alindima deleted the alindima/fix-circle branch November 25, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants