-
Notifications
You must be signed in to change notification settings - Fork 3
Added a read example with smoldot #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bkontur I think it's a good practice to keep one package.json. I added package.json to one of ahm-dryrun subfolders and @seadanda suggested to stick to one package.json because:
- multiple
package.jsonfiles may easily go out of sync and cause a "dependency drift", - tools like tsconfig, jest, etc need to know which workspace they’re running in. Multiple
package.jsoncan lead to configs not being picked up correctly, working in one folder but not another.
Let's maybe revert back to a single package.json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea a single top level file was preferable for ahm-dryrun because we wanted to keep packages in sync and used the same frameworks etc everywhere, but sometimes you don't actually want that, and multiple package.jsons are fine (there are even some tools to manage that flow like npm workspaces/turborepo).
There are legit usecases for each, but I think that the simplest is best unless you need multiple
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's maybe revert back to a single
package.json?
But we have just one examples/package.json.
Point of these examples is to use the same versions as simply as possible and run them as a part of CI. I don't see any reason to have multiple package.json and versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an old comment, it concerned the state of this PR (or related) when we had two package.json, now we have only one so it's already obsolete, I believe.
node examples/smoldot_read.js