Add instant seal to omni-node #10008
Open
+134
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgherveou
commented
Oct 14, 2025
|
Open to add a new option as well if you think that make more sense |
|
/cmd prdoc --audience runtime_dev --bump patch |
pgherveou
added
T7-smart_contracts
…time_dev --bump patch'
|
/cmd fmt |
bkchr
reviewed
Oct 14, 2025
pgherveou
commented
Oct 14, 2025
pgherveou
commented
Oct 14, 2025
pgherveou
commented
Oct 14, 2025
pgherveou
commented
Oct 14, 2025
pgherveou
commented
Oct 14, 2025
Co-authored-by: Iulian Barbu <14218860+iulianbarbu@users.noreply.github.com>
Co-authored-by: Iulian Barbu <14218860+iulianbarbu@users.noreply.github.com>
pgherveou
commented
Oct 14, 2025
bkchr
approved these changes
Oct 14, 2025
pgherveou
commented
Oct 14, 2025
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
|
/cmd fmt |
bkchr
reviewed
Oct 15, 2025
| /// By default this is retrieved from `SharedParams`. | ||
| fn is_dev(&self) -> Result<bool> { | ||
| Ok(self.shared_params().is_dev()) | ||
| fn is_dev(&self) -> bool { |
There was a problem hiding this comment.
Please revert this unrequired change.
There was a problem hiding this comment.
I use is_dev() in this commit, this didnt make any sense, why does it have to return a result?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
--instant-sealCLI flag to enable instant seal mode in omni-node.fixes #9996