pallet_revive: when a dry run simulates contract deployment, return the execution result data. #10032
+39
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marian-radu
changed the title
marian-radu
changed the title
marian-radu
added
the
T7-smart_contracts
pgherveou
force-pushed
the
177-dry-running-deployment-transaction-does-not-return-deployed-bytecode
branch
from
a7397be to
9cac16e
Compare
|
/cmd prdoc --audience runtime_dev --bump patch |
pgherveou
approved these changes
Oct 17, 2025
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
|
/cmd prdoc --audience runtime_dev --bump patch |
…time_dev --bump patch'
athei
approved these changes
Oct 20, 2025
There was a problem hiding this comment.
Code looks good. Tested against this reproducer: paritytech/contract-issues#177 (comment)
Should we add this to the RPC test suite?
Yes, I'm working on adding a test for this scenario to the evm-test-suite. |
…s-not-return-deployed-bytecode
marian-radu
deleted the
177-dry-running-deployment-transaction-does-not-return-deployed-bytecode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes paritytech/contract-issues#177
Expose the deployed contract's runtime bytecode in eth_call responses during simulated contract creation.
The test from issue paritytech/contract-issues#177 sends an eth_call request without a destination address, while providing contract bytecode in the data field. This simulates a contract creation transaction. The test expects the RPC response to return the result of executing the init code, which is the deployed contract's runtime bytecode. While this result is not returned in actual deployments, it is expected in dry-run simulations.