[stable2509] Backport #10051 #10063
Merged
[stable2509] Backport #10051 #10063
+557
−210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![paritytech-release-backport-bot[bot]](https://avatars.githubusercontent.com/in/1084725?s=80&v=4){kind=small}
TLDR: Thanks to a number of reports from Kusama validator, we have been investigating an issue where the self stake of some validators is not present in `ErasStakersPaged` and `ErasStakersOverview`, and consequently not earning staking rewards. After investigation, it was clear that the `polkadot-staking-miner` is doing the right thing, and the self-stake is indeed submitted to the chain as a part of the staking election result. The root cause in how `pallet-staking-async` ingests the staking election result. This code **made a (wrong) assumption that self-stake is only present in the first page of a multi-page election. This PR fixes this issue.** --- - [x] (nice to have) revisit try-state checks of the pallet, `ErasStakersPaged`, `ErasStakersOverview` and `ErasTotalStake` are triple checked for correctness - [ ] (nice to have) fix related displays in PJS: polkadot-js/apps#11930 - [ ] backport to 2507 and 2509 - Westend - [ ] Find a similar issue in westend for monitoring (paritytech/devops#4402) - [ ] Upgrade westend to a branch/release containing this fix - [ ] Upgrade westend with this fix, observe test examples are resolved - [ ] Bump backported version in `fellowship/runtimes` - [ ] Release 1.9.3 for Kusama with this fix - [ ] Ensure known test cases are fixed - One example: `F2WyUUFXLYnBg6acv7t2KFzH6D7CyNcvC4mRCwUdsHTUB4t` (in election round 46, likely repeating in subsequent ones too) - This PR will be part of Polkadot release 2.0.0, the Polkadot AHM. - [ ] Forum post with further explanation once PR is merged. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 56e4b10)
paritytech-release-backport-bot
bot
requested a review
from a team
as a code owner
github-actions
bot
added
the
A3-backport
10 tasks
|
This pull request is amending an existing release. Please proceed with extreme caution,
Emergency Bypass
If you really need to bypass this check: add |
kianenigma
approved these changes
Oct 20, 2025
andreitrand
approved these changes
Oct 20, 2025
muharem
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #10051 into
stable2509from kianenigma.See the documentation on how to use this bot.