Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling - feature PR #1955

Closed
wants to merge 19 commits into from
Closed

Disabling - feature PR #1955

wants to merge 19 commits into from

Conversation

tdimitrov
Copy link
Contributor

@tdimitrov tdimitrov commented Oct 20, 2023

tdimitrov and others added 5 commits October 20, 2023 16:13
Handles validator disabling in the backing subsystem. The PR introduces
two changes:
1. Don't import statements from disabled validators.
2. Don't validate and second if the local validator is disabled.

The purpose of this change is first to ignore statements from disabled
validators on the node side. This is an optimisation as these statements
are supposed to be cleared in the runtime too (still not implemented at
the moment). Additionally if the local node is a validator which is
disabled - don't process any new candidates.

---------

Co-authored-by: ordian <noreply@reusable.software>
Co-authored-by: ordian <write@reusable.software>
* master:
  Removed TODO from test-case for hard-coded delivery fee estimation (#2042)
  Expose collection attributes from `Inspect` trait (#1914)
  `polkadot-parachain-primitives` should not depend on `frame-support`. (#1897)
  [testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way (#2023)
  Sort the benchmarks before listing them (#2026)
  publish pallet-root-testing (#2017)
  Contracts: Add benchmarks to include files (#2022)
  Small optimisation to `--profile dev` wasm builds (#1851)
  basic-authorship: Improve time recording and logging (#2010)
  Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto (#1815)
  [ci] Run check-rust-feature-propagation in pr and master (#2012)
  Improve features dev-ex (#1831)
  Remove obsolete comment. (#2008)
@tdimitrov tdimitrov added the A0-needs_burnin Pull request needs to be tested on a live validator node before merge. DevOps is notified via matrix label Nov 16, 2023
@tdimitrov
Copy link
Contributor Author

All changes here have been backported to master.
Disabling strategy (#2226) is pending review and audit.

This PR is no longer needed.

@tdimitrov tdimitrov closed this Jan 18, 2024
@tdimitrov tdimitrov deleted the tsv-disabling branch January 19, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-needs_burnin Pull request needs to be tested on a live validator node before merge. DevOps is notified via matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants