Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsystem benchmark template to estimate CPU hardware requirements #4323

Closed
wants to merge 20 commits into from

Conversation

alexggh
Copy link
Contributor

@alexggh alexggh commented Apr 29, 2024

No description provided.

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@paritytech-review-bot paritytech-review-bot bot requested a review from a team April 29, 2024 10:26
alexggh and others added 2 commits April 30, 2024 08:33
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh alexggh marked this pull request as ready for review May 8, 2024 08:31
@alexggh alexggh changed the title [DNM] Estimate CPU hw requirements Subsystem benchmark template to estimate CPU hardware requirements May 8, 2024
@alexggh alexggh added the R0-silent Changes should not be mentioned in any release notes label May 8, 2024
@alexggh alexggh requested review from AndreiEres and removed request for a team May 8, 2024 08:33
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
This reverts commit 0227447.
@alexggh alexggh requested a review from a team as a code owner May 16, 2024 14:09
extends:
- .subsystem-benchmark-template
script:
- cargo run -p polkadot-subsystem-bench --release -- polkadot/node/subsystem-bench/examples/estimate_cpu_requirements.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove these so we can merge.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need it in the CI, right? Is it here just to run on a reference hw?

@bkchr
Copy link
Member

bkchr commented Jul 24, 2024

@alexggh do you still want to merge this?

@alexggh
Copy link
Contributor Author

alexggh commented Jul 24, 2024

No, this is stale, I'm closing it.

@alexggh alexggh closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants