Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup storage_version for bridging pallets #4337

Closed
wants to merge 1 commit into from

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Apr 30, 2024

@bkontur bkontur added R0-silent Changes should not be mentioned in any release notes T15-bridges This PR/Issue is related to bridges. labels Apr 30, 2024
@paritytech-review-bot paritytech-review-bot bot requested a review from a team April 30, 2024 14:00
@bkontur bkontur added this pull request to the merge queue Apr 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 30, 2024
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see how this is needed. cc @liamaharon

If there is an issue with pallets that do not have storage versions, then we should fix that and not work around it by setting versions. Not having a version for a pallet should be perfectly fine.

@bkchr
Copy link
Member

bkchr commented Apr 30, 2024

Yes, this should not be needed.

Copy link
Contributor

@liamaharon liamaharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed, storage version is zero if omitted.

That said, there's no harm in specifying it explicitly if people want to establish that pattern in their pallets.

@bkontur
Copy link
Contributor Author

bkontur commented May 1, 2024

I dont see how this is needed. cc @liamaharon

If there is an issue with pallets that do not have storage versions, then we should fix that and not work around it by setting versions. Not having a version for a pallet should be perfectly fine.

No, no, there is no problem :)

My intentions with this PR are just to prepare the bridging pallets for future migrations, which will be introduced with BridgesV2. Additionally, we have other issues that will require migrations. I just thought it would be a good idea to add #[pallet::storage_version] and prepare pallets for migrations.

But let's not complicate, we will add this when needed.

@bkontur bkontur closed this May 1, 2024
@bkchr bkchr deleted the bko-storage-version-for-bridging branch May 2, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T15-bridges This PR/Issue is related to bridges.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add #[pallet::storage_version to the all bridging pallets
6 participants