-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup storage_version
for bridging pallets
#4337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont see how this is needed. cc @liamaharon
If there is an issue with pallets that do not have storage versions, then we should fix that and not work around it by setting versions. Not having a version for a pallet should be perfectly fine.
Yes, this should not be needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed, storage version is zero if omitted.
That said, there's no harm in specifying it explicitly if people want to establish that pattern in their pallets.
No, no, there is no problem :) My intentions with this PR are just to prepare the bridging pallets for future migrations, which will be introduced with BridgesV2. Additionally, we have other issues that will require migrations. I just thought it would be a good idea to add But let's not complicate, we will add this when needed. |
Closes: paritytech/parity-bridges-common#2947